Skip to content

Add change note for sqlite/sqlite_async models and tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Add change note for sqlite/sqlite_async models and tests #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/ql/lib/change-notes/2000-12-12-more-ql-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: test
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category 'test' is not a valid category for library-pack change notes. Based on the description ('Added models for the sqlite and sqlite_async libraries'), this should be categorized as 'feature' since it adds new library APIs/models.

Copilot generated this review using guidance from repository custom instructions.
---
* Added models for the `sqlite` and `sqlite_async` libraries.
* Added tests for the new SQLite models as well.
Comment on lines +4 to +5
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The second bullet point is redundant. Consider combining both points into a single concise statement, such as: 'Added models and tests for the sqlite and sqlite_async libraries.'

Suggested change
* Added models for the `sqlite` and `sqlite_async` libraries.
* Added tests for the new SQLite models as well.
* Added models and tests for the `sqlite` and `sqlite_async` libraries.

Copilot uses AI. Check for mistakes.