Skip to content

Commit 8e20ad5

Browse files
authored
Merge pull request #87 from BoniLindsley/fix-84-letter-case-of-user-repo
Fix shellcheck SC2086: double quote argument
2 parents c0e9f80 + a7a767a commit 8e20ad5

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lib/git-issue/import-export.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@ create_issue()
207207
path=$(issue_path_part "$1") || exit
208208
isha=$(issue_sha "$path")
209209
provider="$2"
210-
user="$(convert_to_lower_case $3)"
211-
repo="$(convert_to_lower_case $4)"
210+
user="$(convert_to_lower_case "$3")"
211+
repo="$(convert_to_lower_case "$4")"
212212

213213
if [ "$provider" = gitlab ] ; then
214214
# if the repo belongs to a group, repo will be in the format groupname/reponame
@@ -815,8 +815,8 @@ export_issues()
815815
test -n "$2" -a -n "$3" || usage_export
816816
test "$1" = github -o "$1" = gitlab || usage_export
817817
provider=$1
818-
user="$(convert_to_lower_case $2)"
819-
repo="$(convert_to_lower_case $3)"
818+
user="$(convert_to_lower_case "$2")"
819+
repo="$(convert_to_lower_case "$3")"
820820

821821
cdissues
822822
test -d "imports/$provider/$user/$repo" || error "No local issues found for this repository."
@@ -891,8 +891,8 @@ sub_import()
891891
test "$1" = github -o "$1" = gitlab -a -n "$2" -a -n "$3" || usage_import
892892
provider="$1"
893893
# convert to lowercase to avoid duplicates
894-
user="$(convert_to_lower_case $2)"
895-
repo="$(convert_to_lower_case $3)"
894+
user="$(convert_to_lower_case "$2")"
895+
repo="$(convert_to_lower_case "$3")"
896896

897897
cdissues
898898

@@ -964,8 +964,8 @@ sub_exportall()
964964
test "$1" = github -o "$1" = gitlab || usage_exportall
965965
test -n "$2" -a -n "$3" || usage_exportall
966966
provider="$1"
967-
user="$(convert_to_lower_case $2)"
968-
repo="$(convert_to_lower_case $3)"
967+
user="$(convert_to_lower_case "$2")"
968+
repo="$(convert_to_lower_case "$3")"
969969

970970
# Create list of relevant shas sorted by date
971971
shas=$(sub_list -l %i -o %c "$all"| sed '/^$/d' | tr '\n' ' ')

0 commit comments

Comments
 (0)