Changes to _get_iv to compute covariant errors#106
Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 45.99% 45.88% -0.12%
==========================================
Files 27 27
Lines 7085 7103 +18
==========================================
Hits 3259 3259
- Misses 3826 3844 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
don't worry about the code-coverage report :) |
Collaborator
Author
|
Okay, thanks! Please let me know if there is any problem. |
Collaborator
Author
|
Hi Dan, I updated the Fisher matrix calculation. Now it's faster by 10 times. Hopefully the version is going to pass all tests. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes to the function _get_iv in optimize.py
The algorithm passed the z-score test where as I fixed the primary source at the center and marched a secondary source along the central x-axis (approaching, overlapping, and then leaving the primary source), I repeated the tractor fit 500 times and plotted a histogram of z-score for each position. The z-score histogram follows a Gaussian of sigma~1 distribution except when the two sources completely overlap. So this is fairly stable. For a three-source test, it's also reasonable.