Expose data numbers and electron counts in info dict when loading SDSS images#24
Open
bpartridge wants to merge 1 commit intodstndstn:mainfrom
Open
Expose data numbers and electron counts in info dict when loading SDSS images#24bpartridge wants to merge 1 commit intodstndstn:mainfrom
bpartridge wants to merge 1 commit intodstndstn:mainfrom
Conversation
Owner
|
Hi Brenton, Sorry for leaving this on the back burner for so long! We could instead add a flag to convert the image into photo-electron units, if that would be useful. I'm a little hesitant to carry around extra image-sized arrays -- that code path is traversed in a lot of projects that don't care about Poisson statistics :) cheers, |
pyloolex
approved these changes
Jan 26, 2021
| meancalib = np.mean(calibvec) | ||
| skysig = sqrt((meansky / gain) + darkvar) * meancalib | ||
|
|
||
| # Calculate the Poisson-distributed number of electrons detected by the instrument |
There was a problem hiding this comment.
It's a better practice to end a sentence with the period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Low priority feature contribution]
Since we're incorporating sky noise in the model for the Inference project, it's useful to expose in
tractor.Imageinstances the calculations described in http://data.sdss3.org/datamodel/files/BOSS_PHOTOOBJ/frames/RERUN/RUN/CAMCOL/frame.html :This patch simply returns image-size vectors in
get_tractor_image_dr8(which is also called if DR9 is passed) for the data-numbers and electron-counts. The caller can then do something likeimg, info = ...; img.counts = np.round(info['dn']).