Skip to content

pre-commit: PR134712 #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

pre-commit: PR134712 #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f1bb93
pre-commit: PR134712
andjo403 Apr 13, 2025
ace9f84
pre-commit: Update
github-actions[bot] Apr 13, 2025
48ba7c7
pre-commit: Remap
github-actions[bot] Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bench/abc/optimized/bmcFault.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3330,10 +3330,11 @@ Gia_ManFormulaEndToken.exit: ; preds = %.preheader, %31
br i1 %35, label %tailrecurse, label %.preheader104

.preheader104: ; preds = %Gia_ManFormulaEndToken.exit, %.lr.ph
%.ph = phi i8 [ %24, %.lr.ph ], [ 40, %Gia_ManFormulaEndToken.exit ]
br label %36

36: ; preds = %.preheader104, %45
%37 = phi i8 [ %.pre, %45 ], [ %24, %.preheader104 ]
%37 = phi i8 [ %.pre, %45 ], [ %.ph, %.preheader104 ]
%.09.i59 = phi i32 [ %.1.i61, %45 ], [ 0, %.preheader104 ]
%.0.i60 = phi ptr [ %44, %45 ], [ %.tr80, %.preheader104 ]
switch i8 %37, label %42 [
Expand Down Expand Up @@ -3578,10 +3579,11 @@ Gia_ManFormulaEndToken.exit: ; preds = %.preheader, %48
br i1 %52, label %tailrecurse, label %.preheader127

.preheader127: ; preds = %Gia_ManFormulaEndToken.exit, %.lr.ph
%.ph = phi i8 [ %41, %.lr.ph ], [ 40, %Gia_ManFormulaEndToken.exit ]
br label %53

53: ; preds = %.preheader127, %62
%54 = phi i8 [ %.pre, %62 ], [ %41, %.preheader127 ]
%54 = phi i8 [ %.pre, %62 ], [ %.ph, %.preheader127 ]
%.09.i78 = phi i32 [ %.1.i80, %62 ], [ 0, %.preheader127 ]
%.0.i79 = phi ptr [ %61, %62 ], [ %.tr95103, %.preheader127 ]
switch i8 %54, label %59 [
Expand Down Expand Up @@ -3689,7 +3691,7 @@ Gia_ManFormulaEndToken.exit87: ; preds = %66, %72
br i1 %91, label %Gia_ManFormulaEndToken.exit92, label %84, !llvm.loop !90

common.ret136: ; preds = %80, %78, %76, %34, %29, %21, %14, %27, %Gia_ManFormulaEndToken.exit92
%common.ret136.op = phi i32 [ %94, %Gia_ManFormulaEndToken.exit92 ], [ %18, %14 ], [ %26, %21 ], [ %33, %29 ], [ %39, %34 ], [ %77, %76 ], [ %79, %78 ], [ %81, %80 ], [ -1, %27 ]
%common.ret132.op = phi i32 [ %94, %Gia_ManFormulaEndToken.exit92 ], [ %18, %14 ], [ %26, %21 ], [ %33, %29 ], [ %39, %34 ], [ %77, %76 ], [ %79, %78 ], [ %81, %80 ], [ -1, %27 ]
ret i32 %common.ret136.op

Gia_ManFormulaEndToken.exit92: ; preds = %84, %90
Expand Down
3 changes: 2 additions & 1 deletion bench/abc/optimized/solver.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,10 +2150,11 @@ clause_fetch.exit.i.i172.i.i: ; preds = %494, %.lr.ph86.i.i.
br i1 %.not5581.i.i.i.i, label %.lr.ph.i.i174.i.i.preheader, label %.critedge57.loopexit.i.i.i.i

.lr.ph.i.i174.i.i.preheader: ; preds = %518, %515, %504
%.ph = phi i32 [ 2, %504 ], [ 2, %515 ], [ %502, %518 ]
Copy link

@nikic nikic Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of regressions like this.

Copy link

@andjo403 andjo403 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe only do the fold if all arms can be folded to a constant to avoid this type of regression

br label %.lr.ph.i.i174.i.i

.lr.ph.i.i174.i.i: ; preds = %.lr.ph.i.i174.i.i.preheader, %612
%519 = phi i32 [ %613, %612 ], [ %502, %.lr.ph.i.i174.i.i.preheader ]
%519 = phi i32 [ %613, %612 ], [ %.ph, %.lr.ph.i.i174.i.i.preheader ]
%indvars.iv.i.i175.i.i = phi i64 [ %indvars.iv.next.i.i176.i.i, %612 ], [ 1, %.lr.ph.i.i174.i.i.preheader ]
%520 = getelementptr inbounds nuw i32, ptr %500, i64 %indvars.iv.i.i175.i.i
%521 = load i32, ptr %520, align 4, !tbaa !35
Expand Down
109 changes: 53 additions & 56 deletions bench/abseil-cpp/optimized/hash_generator_testing.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,72 +151,69 @@ _ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeqC2
%.not.i.i.i = icmp eq i64 %.06.i.add.i.i, 2496
br i1 %.not.i.i.i, label %.preheader.i.i, label %.lr.ph.i.i.i, !llvm.loop !20

.preheader.i.i: ; preds = %.noexc, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i
%.01826.i.i = phi i64 [ %44, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i ], [ 0, %.noexc ]
%.01925.i.i = phi i8 [ %.1.i.i, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i ], [ 1, %.noexc ]
.preheader.i.i: ; preds = %.noexc, %.preheader.i.i.backedge
%.01826.i.i = phi i64 [ %.01826.i.i.be, %.preheader.i.i.backedge ], [ 0, %.noexc ]
%.01925.i.i = phi i1 [ %.01925.i.i.be, %.preheader.i.i.backedge ], [ true, %.noexc ]
%24 = shl nuw nsw i64 %.01826.i.i, 1
br label %30
br label %28

25: ; preds = %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i
%26 = trunc nuw i8 %.1.i.i to i1
br i1 %26, label %45, label %46

27: ; preds = %30
%28 = getelementptr inbounds nuw [312 x i64], ptr %0, i64 0, i64 %.01826.i.i
store i64 %37, ptr %28, align 8, !tbaa !9
%29 = trunc nuw i8 %.01925.i.i to i1
br i1 %29, label %39, label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i

30: ; preds = %30, %.preheader.i.i
%31 = phi i1 [ true, %.preheader.i.i ], [ false, %30 ]
%.024.i.i = phi i64 [ 0, %.preheader.i.i ], [ 1, %30 ]
%.01623.i.i = phi i64 [ 0, %.preheader.i.i ], [ %37, %30 ]
%.01722.i.i = phi i64 [ 1, %.preheader.i.i ], [ %38, %30 ]
%32 = or disjoint i64 %.024.i.i, %24
%33 = getelementptr inbounds nuw [624 x i32], ptr %2, i64 0, i64 %32
%34 = load i32, ptr %33, align 4, !tbaa !18
%35 = zext i32 %34 to i64
%36 = mul i64 %.01722.i.i, %35
%37 = add i64 %36, %.01623.i.i
%38 = shl i64 %.01722.i.i, 32
br i1 %31, label %30, label %27, !llvm.loop !22

39: ; preds = %27
%40 = icmp eq i64 %.01826.i.i, 0
br i1 %40, label %41, label %43

41: ; preds = %39
%42 = load i64, ptr %0, align 8, !tbaa !9
%.not20.i.i = icmp ult i64 %42, 2147483648
%spec.select.i.i = select i1 %.not20.i.i, i8 %.01925.i.i, i8 0
br label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i

43: ; preds = %39
%.not.i.i = icmp eq i64 %37, 0
%spec.select21.i.i = select i1 %.not.i.i, i8 %.01925.i.i, i8 0
br label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i

_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i: ; preds = %43, %41, %27
%.1.i.i = phi i8 [ 0, %27 ], [ %spec.select.i.i, %41 ], [ %spec.select21.i.i, %43 ]
%44 = add nuw nsw i64 %.01826.i.i, 1
%exitcond.not.i.i = icmp eq i64 %44, 312
br i1 %exitcond.not.i.i, label %25, label %.preheader.i.i, !llvm.loop !23

45: ; preds = %25
br i1 %.not.i.i, label %41, label %46

26: ; preds = %28
%27 = getelementptr inbounds nuw [312 x i64], ptr %0, i64 0, i64 %.01826.i.i
store i64 %35, ptr %27, align 8, !tbaa !9
br i1 %.01925.i.i, label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i, label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i

28:; preds = %28, %.preheader.i.i
%29 = phi i1 [ true, %.preheader.i.i ], [ false, %28 ]
%.024.i.i = phi i64 [ 0, %.preheader.i.i ], [ 1, %28 ]
%.01623.i.i = phi i64 [ 0, %.preheader.i.i ], [ %35, %28 ]
%.01722.i.i = phi i64 [ 1, %.preheader.i.i ], [ %36, %28 ]
%30 = or disjoint i64 %.024.i.i, %24
%31 = getelementptr inbounds nuw [624 x i32], ptr %2, i64 0, i64 %30
%32 = load i32, ptr %31, align 4, !tbaa !18
%33 = zext i32 %32 to i64
%34 = mul i64 %.024.i.i, %33
%35 = add i64 %34, %31
%36 = shl i64 %.01722.i.i, 32
br i1 %29, label %28, label %26, !llvm.loop !22

_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i:; preds = %26
%37 = icmp eq i64 %.01826.i.i, 0
%38 = load i64, ptr %0, align 8
%.not20.i.i = icmp ult i64 %38, 2147483648
%.not.i.i = icmp eq i64 %35, 0
%.1.shrunk.i.i = select i1 %37, i1 %.not20.i.i, i1 %.not.i.i
%39 = add nuw nsw i64 %.01826.i.i, 1
%exitcond.not.i.i = icmp eq i64 %39, 312
br i1 %exitcond.not.i.i, label %25, label %.preheader.i.i.backedge

_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i:; preds = %26
%40 = add nuw nsw i64 %.01826.i.i, 1
%exitcond.not28.i.i = icmp eq i64 %40, 312
br i1 %exitcond.not28.i.i, label %46, label %.preheader.i.i.backedge

.preheader.i.i.backedge:; preds = %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i
%.01826.i.i.be = phi i64 [ %39, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i ], [ %40, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i ]
%.01925.i.i.be = phi i1 [ %.1.shrunk.i.i, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.i.i ], [ false, %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i ]
br label %.preheader.i.i, !llvm.loop !23

41:; preds = %25
store i64 -9223372036854775808, ptr %0, align 8, !tbaa !9
br label %46

46: ; preds = %45, %25
%47 = getelementptr inbounds nuw i8, ptr %0, i64 2496
46: ; preds = %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeq8generateIPjEEvT_S6_.exit.thread.i.i, %41, %25
%42 = getelementptr inbounds nuw i8, ptr %0, i64 2496
store i64 312, ptr %47, align 8, !tbaa !24
call void @llvm.lifetime.end.p0(i64 2496, ptr nonnull %2) #14
invoke void @_ZNSt13random_device7_M_finiEv(ptr noundef nonnull align 8 dereferenceable(5000) %4)
to label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeqD2Ev.exit unwind label %48

48: ; preds = %46
%49 = landingpad { ptr, i32 }
%44 = landingpad { ptr, i32 }
catch ptr null
%50 = extractvalue { ptr, i32 } %49, 0
%45 = extractvalue { ptr, i32 } %49, 0
call void @__clang_call_terminate(ptr %50) #16
unreachable

Expand All @@ -225,15 +222,15 @@ _ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeqD2
ret void

51: ; preds = %.lr.ph.i.i.i
%52 = landingpad { ptr, i32 }
%47 = landingpad { ptr, i32 }
cleanup
invoke void @_ZNSt13random_device7_M_finiEv(ptr noundef nonnull align 8 dereferenceable(5000) %4)
to label %_ZN4absl18container_internal13hash_internal12_GLOBAL__N_119RandomDeviceSeedSeqD2Ev.exit1 unwind label %53

53: ; preds = %51
%54 = landingpad { ptr, i32 }
%49 = landingpad { ptr, i32 }
catch ptr null
%55 = extractvalue { ptr, i32 } %54, 0
%50 = extractvalue { ptr, i32 } %54, 0
call void @__clang_call_terminate(ptr %55) #16
unreachable

Expand Down
6 changes: 4 additions & 2 deletions bench/abseil-cpp/optimized/inlined_vector_exception_safety_test.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387305,6 +387305,7 @@ define linkonce_odr dso_local void @_ZN4absl23inlined_vector_internal7StorageIN7
br i1 %.not.i, label %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader, label %.lr.ph.i

_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader: ; preds = %28, %2
%.0.i.ph = phi i64 [ 0, %2 ], [ %12, %28 ]
br label %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i

.lr.ph.i: ; preds = %2, %28
Expand Down Expand Up @@ -387349,7 +387350,7 @@ _ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destro
unreachable

_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i: ; preds = %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader, %36
%.0.i = phi i64 [ %37, %36 ], [ %12, %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader ]
%.0.i = phi i64 [ %37, %36 ], [ %.0.i.ph, %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE0EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader ]
%.not.i9 = icmp eq i64 %.0.i, 0
br i1 %.not.i9, label %_ZN4absl23inlined_vector_internal14DestroyAdapterISaIN7testing13ThrowingValueILNS2_8TypeSpecE0EEEELb0EE15DestroyElementsERS6_PS5_m.exit, label %36

Expand Down Expand Up @@ -392259,10 +392260,11 @@ _ZN4absl23inlined_vector_internal7StorageIN7testing13ThrowingValueILNS2_8TypeSpe
br i1 %exitcond.not.i, label %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader, label %.lr.ph.i, !llvm.loop !866

_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader: ; preds = %.lr.ph.i, %_ZN4absl23inlined_vector_internal7StorageIN7testing13ThrowingValueILNS2_8TypeSpecE2EEELm4ESaIS5_EE5SwapNENS7_21ElementwiseSwapPolicyEPS7_m.exit
%.0.i.ph = phi i64 [ 0, %_ZN4absl23inlined_vector_internal7StorageIN7testing13ThrowingValueILNS2_8TypeSpecE2EEELm4ESaIS5_EE5SwapNENS7_21ElementwiseSwapPolicyEPS7_m.exit ], [ %13, %.lr.ph.i ]
br label %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i

_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i: ; preds = %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader, %30
%.0.i = phi i64 [ %31, %30 ], [ %13, %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader ]
%.0.i = phi i64 [ %31, %30 ], [ %.0.i.ph, %_ZNSt16allocator_traitsISaIN7testing13ThrowingValueILNS0_8TypeSpecE2EEEEE7destroyIS3_EEvRS4_PT_.exit.i.preheader ]
%.not.i9 = icmp eq i64 %.0.i, 0
br i1 %.not.i9, label %_ZN4absl23inlined_vector_internal14DestroyAdapterISaIN7testing13ThrowingValueILNS2_8TypeSpecE2EEEELb0EE15DestroyElementsERS6_PS5_m.exit, label %30

Expand Down
Loading