Use ExpandingTextareas plugin over the dated Elastic#2
Open
waynehoover wants to merge 3 commits intodtime:masterfrom
Open
Use ExpandingTextareas plugin over the dated Elastic#2waynehoover wants to merge 3 commits intodtime:masterfrom
waynehoover wants to merge 3 commits intodtime:masterfrom
Conversation
Member
|
Thanks for the pull, Wayne. I'm going to try it out on our staging server before merging it in, since I try to keep this fork in sync with our site - but looks great on the demo html. I know we've had trouble with the elastic plugin before. |
Member
|
Hmm, looks like the new plugin doesn't always preserve CSS like it is supposed to (loses my min-height property). Seems weird since there's a test case for that in their demo. I'll have to look and see if it's some combination of styles that break it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for this fork. Thought you might be interested in using the excellent ExpandingTextareas plugin over the elastic. Elastic had some hacks and always gave weird results when I tried to do the most basic of styling to my textarea. (ExpandingTextareas)[https://github.com/bgrins/ExpandingTextareas] is based on an excellent article on AListApart about expanding textareas, and works like a charm every time. Its also maintained, which is why I submit this patch to your repo and not upstream to podio :)
I included the lib as a submodule, because hey its more fun that way :) I also updated the index.html in the docs.