Conversation
r41d
commented
May 12, 2025
- feat(dtnecho.py): add possibility to use custom port names
- feat(dtntrigger): add simple print functionality
- feat(dtnsend): add option to pass message directly as paramter
gh0st42
left a comment
There was a problem hiding this comment.
Thank you for the PR, some nice finds but some things are still unclear.
Mainly the use of chrono and the send message parameter I do not see why it would be needed.
There was a problem hiding this comment.
what's the problem with "echo test | dtnsend" ? why introduce more code to do the same? I do not see a use case, pleasure explain
There was a problem hiding this comment.
I found it to be more tedious to use pipes rather than having the command, especially when using dtnsend in contexts where it's not just called from the command line but, for example, in a script of invoked from other places. So essentially the reason is that I found it much more comfortable to work with and I don't think it's too much code. But if you absolutely object it I would remove it.
There was a problem hiding this comment.
i think i would keep it in line with other unix tools such as netcat that also just use pipes, less code duplication and following the unix philosophy
This reverts commit b08949a.