Skip to content

Program enhancements#71

Merged
gh0st42 merged 8 commits intodtn7:masterfrom
r41d:program-enhancements
Sep 17, 2025
Merged

Program enhancements#71
gh0st42 merged 8 commits intodtn7:masterfrom
r41d:program-enhancements

Conversation

@r41d
Copy link
Contributor

@r41d r41d commented May 12, 2025

  • feat(dtnecho.py): add possibility to use custom port names
  • feat(dtntrigger): add simple print functionality
  • feat(dtnsend): add option to pass message directly as paramter

Copy link
Member

@gh0st42 gh0st42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, some nice finds but some things are still unclear.
Mainly the use of chrono and the send message parameter I do not see why it would be needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the problem with "echo test | dtnsend" ? why introduce more code to do the same? I do not see a use case, pleasure explain

Copy link
Contributor Author

@r41d r41d Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it to be more tedious to use pipes rather than having the command, especially when using dtnsend in contexts where it's not just called from the command line but, for example, in a script of invoked from other places. So essentially the reason is that I found it much more comfortable to work with and I don't think it's too much code. But if you absolutely object it I would remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i would keep it in line with other unix tools such as netcat that also just use pipes, less code duplication and following the unix philosophy

@r41d r41d requested a review from gh0st42 September 2, 2025 12:09
@gh0st42 gh0st42 merged commit 44ca55b into dtn7:master Sep 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants