Skip to content

Include typename in diagnostic on unsupported type #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Include typename in diagnostic on unsupported type #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cca5215
Diagnostic improvement.
adetaylor Oct 23, 2020
dbc5377
Avoid repeating the underlined type in the label
dtolnay Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion syntax/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ fn check_type_ident(cx: &mut Check, ident: &Ident) {
&& !cx.types.cxx.contains(ident)
&& !cx.types.rust.contains(ident)
{
cx.error(ident, "unsupported type");
let msg = format!("unsupported type: {}", ident);
cx.error(ident, &msg);
}
}

Expand Down
7 changes: 7 additions & 0 deletions syntax/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ pub static ERRORS: &[Error] = &[
DISCRIMINANT_OVERFLOW,
DOUBLE_UNDERSCORE,
RUST_TYPE_BY_VALUE,
UNSUPPORTED_TYPE,
USE_NOT_ALLOWED,
];

Expand Down Expand Up @@ -66,6 +67,12 @@ pub static RUST_TYPE_BY_VALUE: Error = Error {
note: Some("hint: wrap it in a Box<>"),
};

pub static UNSUPPORTED_TYPE: Error = Error {
msg: "unsupported type: ",
label: Some("unsupported type"),
note: None,
};

pub static USE_NOT_ALLOWED: Error = Error {
msg: "`use` items are not allowed within cxx bridge",
label: Some("not allowed"),
Expand Down