Tweak sparse registry conditional #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
Feb 15, 2023
| then | ||
| echo CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse >> $GITHUB_ENV | ||
| if [ -z ${CARGO_REGISTRIES_CRATES_IO_PROTOCOL+set} ]; then | ||
| if rustc +${{steps.parse.outputs.toolchain}} --version --verbose | not grep -q '^release: 1\.6[67]\.'; then |
There was a problem hiding this comment.
It may also need to check commit-date since it's only stabilized after 2023-01-20 or later: rust-lang/rust#107120, but the rustc release was already at 1.68.
See https://github.com/pola-rs/polars/actions/runs/4183969359/jobs/7249008618
jonasbb
added a commit
to actions-rust-lang/setup-rust-toolchain
that referenced
this pull request
Feb 15, 2023
These issues are reported again rust-toolchain from which the code is inspired. dtolnay/rust-toolchain#71 dtolnay/rust-toolchain#69 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try whether this fixes #68.