Skip to content

Use physical quantities in settings, improve data generators#10

Merged
nikolasborrel merged 2 commits intomainfrom
nikolasborrel_physical_settings
Nov 9, 2025
Merged

Use physical quantities in settings, improve data generators#10
nikolasborrel merged 2 commits intomainfrom
nikolasborrel_physical_settings

Conversation

@nikolasborrel
Copy link
Member

Summary

Breaking Changes ⚠️

  • Settings files: JSON configuration now uses physical quantities instead of normalized values
    • tmax: Now in physical time units (seconds) instead of normalized time
    • f0_feat: Fourier feature frequencies now in physical units (Hz) instead of normalized frequencies
    • All JSON setup files in json_setups/ have been updated to reflect this change
    • Migration: Users with existing settings files need to convert normalized values to physical units

This PR improves code documentation and usability

Nikolas Borrel-Jensen added 2 commits November 9, 2025 17:09
…ersion

- Convert relative imports to absolute imports for consistency
- Update pre-commit ruff from v0.1.0 to v0.14.4
- Add ruff-format hook to pre-commit config

This fixes the linting conflict where local ruff (v0.14.1) and
pre-commit ruff (v0.1.0) were formatting imports differently.
@nikolasborrel nikolasborrel merged commit 553e461 into main Nov 9, 2025
1 check passed
@nikolasborrel nikolasborrel deleted the nikolasborrel_physical_settings branch November 9, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant