Skip to content

Normalize u pressure fields from data instead of assuming fixed range#8

Merged
nikolasborrel merged 4 commits intomainfrom
nikolasborrel_normalize_u
Nov 2, 2025
Merged

Normalize u pressure fields from data instead of assuming fixed range#8
nikolasborrel merged 4 commits intomainfrom
nikolasborrel_normalize_u

Conversation

@nikolasborrel
Copy link
Member

@nikolasborrel nikolasborrel commented Nov 2, 2025

Refactor data generators and improve CI performance

Data Generator Refactoring

Pressure normalization improvements:

  • Auto-calculate min/max pressure values from datasets (up to 500 samples)
  • Add u_pressures(idx) method for consistent normalized pressure retrieval
  • Remove hardcoded (-2.0, 2.0) assumption

Code quality:

  • Remove simple property getters, use public attributes directly
  • Extract shared normalization logic into helper functions
  • Add type annotations for class attributes

PEP 8 compliance:

  • Rename methods to snake_case (normalizeSpatialnormalize_spatial, etc.)

Testing

  • Added unit tests for new functionality

@nikolasborrel nikolasborrel merged commit 11ff54d into main Nov 2, 2025
1 check passed
@nikolasborrel nikolasborrel deleted the nikolasborrel_normalize_u branch November 2, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant