-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update package manager version to 9.15.9 #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@selcukcukur is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughPackage manager version is updated from [email protected] to [email protected] in the package.json configuration. No changes to scripts, dependencies, or resolutions. Build workflow remains unaffected. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "chrono-node": "2.7.5" | ||
| }, | ||
| "packageManager": "pnpm@8.6.10" | ||
| "packageManager": "pnpm@9.15.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check lockfile status, CI/CD configurations, and package.json
echo "=== Checking pnpm-lock.yaml status ==="
if [ -f "pnpm-lock.yaml" ]; then
echo "✓ pnpm-lock.yaml exists"
head -n 10 pnpm-lock.yaml | grep -E "^(lockfileVersion|version):" || echo "(checking lockfile version info)"
else
echo "✗ pnpm-lock.yaml not found"
fi
echo -e "\n=== Current packageManager in package.json ==="
cat package.json | jq -r '.packageManager' 2>/dev/null || grep "packageManager" package.json
echo -e "\n=== CI/CD workflows referencing pnpm ==="
find .github/workflows -type f \( -name "*.yml" -o -name "*.yaml" \) 2>/dev/null | head -5
if [ -d ".github/workflows" ]; then
echo -e "\n=== Checking for hardcoded pnpm versions in workflows ==="
grep -r "pnpm@" .github/workflows 2>/dev/null || echo "No hardcoded pnpm versions found"
grep -r "uses.*pnpm" .github/workflows 2>/dev/null || echo "No pnpm action references found"
fi
echo -e "\n=== Check for latest pnpm versions ==="
npm view pnpm versions --json 2>/dev/null | tail -20 || echo "Could not fetch from npm"Repository: dubinc/dub
Length of output: 1064
🌐 Web query:
pnpm 9.15.9 breaking changes issues
💡 Result:
Summary — pnpm 9.15.9 and related 9.15.x issues
- 9.15.9 itself is a patch that fixes a Windows-specific problem: running the pnpm CLI from the pnpm CLI when the CLI is bundled into an executable. [1]
- Related 9.15.x regressions reported around the same time:
- Problems with switching/activating 9.15.4/9.15.3 when a system has pnpm v10+ installed (empty tool folder created, switch fails); several issues/workarounds reported (downgrade to 9.15.3 or 9.15.0 as temporary workarounds). [2]
pnpm self-update/ global install reporting or activating the wrong version in some environments. Multiple GitHub issues and reports exist. [3][2]
Sources
[1] Release notes for v9.15.9 (patch: “Fix running pnpm CLI from pnpm CLI on Windows when the CLI is bundled to an executable”). (GitHub Releases).
[2] GitHub issue: “pnpm 9.15.4 switch broken when running pnpm v10+” (#8971).
[3] GitHub issue: “pnpm -version reports the incorrect version after pnpm self-update” (#8848) and related global-install/version reports (#9021).
If you want, I can open the specific issue threads and show exact error excerpts or suggested workarounds for your OS.
Address known regressions in pnpm 9.15.9 before merging.
While the lockfile has been properly regenerated (lockfileVersion: '9.0') and CI/CD is configured to handle multiple pnpm versions via pnpm/action-setup@v3, pnpm 9.15.9 has documented regressions that warrant attention:
- pnpm 9.15.x switching issues: Known problems when a system has pnpm v10+ installed, including failed version switching and tool folder creation errors
- Version reporting inconsistencies:
pnpm self-updateand global installs may report or activate incorrect versions in some environments
Consider either downgrading to an earlier 9.x patch (like 9.15.0 or earlier in the 9.x line) or upgrading to pnpm 10.26.1 (the latest stable version), depending on your stability requirements and timeline.
🤖 Prompt for AI Agents
In package.json at line 35, the packageManager entry pins pnpm to 9.15.9 which
has known regressions; update this value to a safe version (either downgrade to
"[email protected]" or upgrade to "[email protected]" depending on your stability choice),
then regenerate the lockfile by running a clean install (pnpm install) and
commit the updated lockfile; additionally ensure CI workflows that use
pnpm/action-setup are pinned/validated to the matching pnpm version to avoid
switching issues in CI agents.
|
Thank you for the PR! Closing this as a duplicate of #3214 🙏 |
In version 8.x, dependencies and other parts already cause quite a lot of issues. The recommended version is 9.5.19, where installation can be carried out in the most stable way.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.