Increases font size on text-area on smaller screen sizes#3481
Increases font size on text-area on smaller screen sizes#3481steven-tey merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis pull request adjusts the responsive typography of a textarea element in the long-text-field form component. The styling change replaces a fixed "text-sm" class with "text-base md:text-sm" to display larger text on small screens and revert to smaller text on medium screens and above. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/ui/partners/groups/design/application-form/fields/long-text-field.tsx (1)
28-34: Apply the same responsive text-size guard to other input fields.Sibling components require the same fix:
short-text-field.tsx(line 34) andwebsite-and-socials-field.tsx(lines 68, 91, 115, 139, 163, 187) both use baretext-smon input elements without thetext-base md:text-smresponsive guard. Update them to match the pattern in this fix to prevent iOS zoom issues across the application-form field suite.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/ui/partners/groups/design/application-form/fields/long-text-field.tsx` around lines 28 - 34, Update the input className usages in short-text-field.tsx and website-and-socials-field.tsx to use the same responsive text-size guard as long-text-field (replace bare "text-sm" with "text-base md:text-sm"); specifically, locate input elements in ShortTextField and the various input elements in WebsiteAndSocialsField that currently include "text-sm" in their className and change that token to "text-base md:text-sm" while preserving all other conditional/error classes and spacing so the responsive behavior and error styling remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@apps/web/ui/partners/groups/design/application-form/fields/long-text-field.tsx`:
- Around line 28-34: Update the input className usages in short-text-field.tsx
and website-and-socials-field.tsx to use the same responsive text-size guard as
long-text-field (replace bare "text-sm" with "text-base md:text-sm");
specifically, locate input elements in ShortTextField and the various input
elements in WebsiteAndSocialsField that currently include "text-sm" in their
className and change that token to "text-base md:text-sm" while preserving all
other conditional/error classes and spacing so the responsive behavior and error
styling remain unchanged.
The change is on text fields, but wasn't on text areas to
text-base. Fixes the ios zoom on focus bug.Summary by CodeRabbit