Add Astro Extension v1.0.0 - Comprehensive astronomical calculations … #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, I am not sure what's up with the CI setup, let me check and come back to you. |
carlopi
reviewed
Jun 15, 2025
|
|
||
| repo: | ||
| github: bjoernbethge/astro-duck | ||
| ref: main |
Collaborator
There was a problem hiding this comment.
ref: is intended to be a git sha, pointing to a reference commit, and that then it's bumped on changes
Collaborator
|
@bjoernbethge: I saw you are iterating on the repo, also great. I can help with the Wasm-side, Windows looks like it's about using a common define. One possible path is also removing some platforms, like for example https://github.com/duckdb/community-extensions/blob/main/extensions/blockduck/description.yml where windows & wasm platforms are removed. Then a subsequent PR can re-enable them when they are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for DuckDB