Add script to check for static library differences#62
Add script to check for static library differences#62maiadegraaf wants to merge 1 commit intoduckdb:mainfrom
Conversation
taniabogatsch
left a comment
There was a problem hiding this comment.
Thanks!! Looks good from my side, but maybe @mlafeldt can have a look, too? Would love to see this integrated into the fetch libs CI somehow, so that we can check if we're all synced up. 🤔
|
Should be easy to add to the CI, just have to pass the hash. We can add a run that is triggered by InvokeCI, using the NotifyExternalRepositories.yml workflow. |
|
To be honest, I haven't understood the goal of this script yet. When we upgrade via the fetch action, we just copy the new libs over. Is this the step you want to verify after the fact (e.g. to avoid partial/failed extraction)? If a file is missing in lib/ but present in prebuilt.go, we'd notice that If a file is missing in prebuilt.go but present in lib/, we won't notice right now - and IMO that would be a good use case for a script, to avoid bugs like #60. |
yes, the script should check this case |
Usage: ./scripts/static-lib-diff-check.sh -h [-v ] | -l <local_path>
Compare Go static libraries with DuckDB static libraries.
Options:
-h Git commit hash (required for download, e.g., 431ad092c9)
-v Optional version tag (e.g., 1.4.0 or v1.4.0)
-l <local_path> Use local directory instead of downloading
Examples: