Skip to content

Add script to check for static library differences#62

Open
maiadegraaf wants to merge 1 commit intoduckdb:mainfrom
maiadegraaf:static-library-diff
Open

Add script to check for static library differences#62
maiadegraaf wants to merge 1 commit intoduckdb:mainfrom
maiadegraaf:static-library-diff

Conversation

@maiadegraaf
Copy link

Usage: ./scripts/static-lib-diff-check.sh -h [-v ] | -l <local_path>

Compare Go static libraries with DuckDB static libraries.

Options:

-h Git commit hash (required for download, e.g., 431ad092c9)
-v Optional version tag (e.g., 1.4.0 or v1.4.0)
-l <local_path> Use local directory instead of downloading

Examples:

  ./scripts/static-lib-diff-check.sh -h 431ad092c9              # Download from hash
  ./scripts/static-lib-diff-check.sh -h 431ad092c9 -v 1.4.0     # Download from hash with version tag
  ./scripts/static-lib-diff-check.sh -l ./static-libs           # Use local files

Copy link
Collaborator

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Looks good from my side, but maybe @mlafeldt can have a look, too? Would love to see this integrated into the fetch libs CI somehow, so that we can check if we're all synced up. 🤔

@maiadegraaf
Copy link
Author

Should be easy to add to the CI, just have to pass the hash. We can add a run that is triggered by InvokeCI, using the NotifyExternalRepositories.yml workflow.

@mlafeldt
Copy link
Member

To be honest, I haven't understood the goal of this script yet.

When we upgrade via the fetch action, we just copy the new libs over. Is this the step you want to verify after the fact (e.g. to avoid partial/failed extraction)?

If a file is missing in lib/ but present in prebuilt.go, we'd notice that go build fails already.

If a file is missing in prebuilt.go but present in lib/, we won't notice right now - and IMO that would be a good use case for a script, to avoid bugs like #60.

@taniabogatsch
Copy link
Collaborator

If a file is missing in prebuilt.go but present in lib/, we won't notice right now - and IMO that would be a good use case for a script, to avoid bugs like

yes, the script should check this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants