Skip to content

Add test for instantiating persistent secrets in parallel #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mytherin merged 2 commits into from
Jan 29, 2026
Merged

Add test for instantiating persistent secrets in parallel #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753a55f
Add test for instantiating persistent secrets in parallel
Mytherin Jan 27, 2026
59daa3f
Merge branch 'main' into instantiatesecretsparallel
Mytherin Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion test/sql/secrets/create_secret_minio.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,29 @@ copy (select 1 as a) to 's3://test-bucket/only-this-file-gets-auth.parquet'
# Its still scoped
statement error
copy (select 1 as a) to 's3://test-bucket/no-auth-here.parquet'
----
----

# start reading persistent secrets concurrently
loop z 0 100

restart

statement ok
set s3_access_key_id='';

statement ok
set s3_secret_access_key='';

statement ok
set secret_directory='__TEST_DIR__/create_secret_minio'

concurrentloop i 0 10

query I
FROM 's3://test-bucket/only-this-file-gets-auth.parquet'
----
1

endloop

endloop
Loading