Skip test on Windows, to be investigated curl global options
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working theory it's that curl is now used both in duckdb-httpfs AND duckdb-spatial (via GDAL) and there is some shared global state. To be investigated, but for now skipping Windows. Note that the problem is very borderline: if your machine has (via configuration) already a certificate verification method, that can't be overridden. This is relevant to look into, but the happy path where one do not mess with certificate will keep working, what's off (in some Windows configuration only) is the capability of overriding certificates.
Collaborator
Author
|
Test-only, CI is irrelevant here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working theory it's that curl is now used both in duckdb-httpfs AND duckdb-spatial (via GDAL) and there is some shared global state. To be investigated, but for now skipping Windows.
Note that the problem is very borderline: if your machine has (via configuration) already a certificate verification method, that can't be overridden. This is relevant to look into, but the happy path where one do not mess with certificate will keep working, what's off (in some Windows configuration only) is the capability of overriding certificates.