allow unsupported platform when duckdb.node present#350
Merged
jraymakers merged 1 commit intoduckdb:mainfrom Dec 28, 2025
Merged
allow unsupported platform when duckdb.node present#350jraymakers merged 1 commit intoduckdb:mainfrom
jraymakers merged 1 commit intoduckdb:mainfrom
Conversation
jraymakers
approved these changes
Dec 28, 2025
Collaborator
jraymakers
left a comment
There was a problem hiding this comment.
Seems like a reasonable extension point, with little to no impact for supported cases.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if you try to run duckdb-node-neo on an unsupported platform, it will always fail.
This PR changes that and will try to load a library with the name
@duckdb/node-bindings/${platform}-${arch}/duckdb.noderegardless if it is a supported platform.This will allow third party authors to create libraries for platforms that are not officially supported. Users can then install these libraries using an alias which is supported by all major Node.js package managers:
For example if someone publishes a library which provides a
duckdb.nodefor FreeBSD, it could be installed like this:And now it will be picked up by
getNativeNodeBindingafter this change.If a library is not present, it will fail with the same error as before.