Skip to content

Link MSVC runtime library statically #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Link MSVC runtime library statically #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ project(duckdb_py LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

# Set the library name
set(DUCKDB_PYTHON_LIB_NAME "_duckdb")
Expand Down
2 changes: 0 additions & 2 deletions cmake/duckdb_loader.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ function(_duckdb_create_interface_target target_name)
/wd26451
/wd26495 # suppress Code Analysis
/D_CRT_SECURE_NO_WARNINGS # suppress warnings about unsafe functions
/D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR # see
# https://github.com/duckdblabs/duckdb-internal/issues/5151
/utf-8 # treat source files as UTF-8 encoded
)
elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
Expand Down