Skip to content

Fix on-pr workflow #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Fix on-pr workflow #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a965f4e
Fix on-pr workflow
Jul 14, 2025
ba73967
Allow empty git ref for checkout
Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ on:
git_ref:
type: string
description: Git ref of the DuckDB python package
default: refs/heads/main
required: true
required: false
duckdb_git_ref:
type: string
description: Git ref of DuckDB
required: false
testsuite:
type: choice
description: Testsuite to run ('all' or 'fast')
Expand All @@ -23,9 +23,10 @@ on:
git_ref:
type: string
description: Git ref of the DuckDB python package
required: true
required: false
duckdb_git_ref:
type: string
required: false
testsuite:
type: string
description: Testsuite to run ('all' or 'fast')
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/on_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ concurrency:
cancel-in-progress: true

jobs:

packaging_test:
name: Build a minimal set of packages and run all tests on them
# Skip packaging tests for draft PRs
Expand All @@ -27,13 +28,12 @@ jobs:
with:
minimal: true
testsuite: all
git_ref: ${{ github.ref }}
duckdb_git_ref: ${{ github.ref_name }}
duckdb_git_ref: ${{ github.base_ref }}

coverage_test:
name: Run coverage tests
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
uses: ./.github/workflows/coverage.yml
with:
git_ref: ${{ github.ref }}
duckdb_git_ref: ${{ github.base_ref }}
testsuite: all
7 changes: 3 additions & 4 deletions .github/workflows/pypi_packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ on:
git_ref:
type: string
description: Git ref of the DuckDB python package
required: true
default: refs/heads/main
required: false
duckdb_git_ref:
type: string
description: Git ref of DuckDB
Expand All @@ -44,11 +43,11 @@ on:
git_ref:
type: string
description: Git ref of the DuckDB python package
required: true
required: false
duckdb_git_ref:
type: string
description: Git ref of DuckDB
required: true
required: false
force_version:
description: Force version (vX.Y.Z-((rc|post)N))
required: false
Expand Down