Skip to content

Conversation

evertlammerts
Copy link
Collaborator

Fixes #74

This PR:

  • exports the adbc_driver_duckdb package so you can use it after pip install duckdb

  • doesn't just skip the tests if the package can't be found

  • limits the exported symbols to the only two that are ever needed: duckdb_adbc_init and PyInit__duckdb:

      ❯ nm -g -C -P .venv/lib/python3.11/site-packages/_duckdb.cpython-311-darwin.so | ag -v ' U '
      _PyInit__duckdb T 41900 0
      _duckdb_adbc_init T 1054e6c 0
    

@evertlammerts evertlammerts marked this pull request as draft September 24, 2025 11:20
@evertlammerts evertlammerts marked this pull request as ready for review September 24, 2025 11:48
@evertlammerts evertlammerts marked this pull request as draft September 24, 2025 12:17
@evertlammerts evertlammerts marked this pull request as ready for review September 25, 2025 12:25
@evertlammerts evertlammerts merged commit 27b1d79 into duckdb:v1.4-andium Sep 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant