Skip to content

Skip test to get working build #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2025
Merged

Skip test to get working build #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fc4ccb
bump submodule
evertlammerts Sep 26, 2025
1ff99dd
skip failing test while bug is fixed in core
evertlammerts Sep 26, 2025
9dc21da
now xfail correct test :/
evertlammerts Sep 26, 2025
f3e406b
Merge branch 'main' into test_skip_19154
evertlammerts Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/duckdb
Open in desktop
Submodule duckdb updated 27 files
+6 −0 .github/workflows/Main.yml
+21 −0 src/common/enum_util.cpp
+7 −0 src/common/settings.json
+15 −2 src/function/table/read_duckdb.cpp
+8 −0 src/include/duckdb/common/enum_util.hpp
+17 −0 src/include/duckdb/common/enums/storage_block_prefetch.hpp
+11 −0 src/include/duckdb/main/settings.hpp
+23 −0 src/include/duckdb/parser/parser_extension.hpp
+4 −0 src/include/duckdb/storage/block_manager.hpp
+2 −0 src/include/duckdb/storage/single_file_block_manager.hpp
+3 −2 src/main/config.cpp
+7 −0 src/main/settings/autogenerated_settings.cpp
+4 −0 src/optimizer/late_materialization.cpp
+14 −0 src/parser/parser.cpp
+1 −1 src/storage/checkpoint_manager.cpp
+14 −0 src/storage/single_file_block_manager.cpp
+7 −6 src/storage/standard_buffer_manager.cpp
+1 −8 src/storage/table/row_group.cpp
+0 −2 src/transaction/duck_transaction_manager.cpp
+1 −0 test/api/test_reset.cpp
+5 −0 test/configs/prefetch_all_storage.json
+23 −0 test/extension/loadable_extension_demo.cpp
+32 −0 test/extension/loadable_parser_override.test
+8 −0 test/helpers/test_config.cpp
+1 −0 test/include/test_config.hpp
+54 −0 test/sql/storage/read_duckdb/read_duckdb_top_n.test
+36 −0 test/sql/storage/read_duckdb/read_duckdb_tpch.test_slow
17 changes: 9 additions & 8 deletions tests/fast/test_replacement_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,15 +288,15 @@ def test_cte_with_joins(self, duckdb_cursor):
WHERE a < 3
)
SELECT * FROM (
SELECT
cte1.*,
SELECT
cte1.*,
cte2.a AS cte2_a,
subquery.a AS cte3_a
FROM cte1
JOIN cte2 ON cte1.a = cte2.a
JOIN (
SELECT
df.*,
SELECT
df.*,
cte3.a AS cte3_a
FROM df
JOIN cte3 ON df.a = cte3.a
Expand All @@ -309,6 +309,7 @@ def test_cte_with_joins(self, duckdb_cursor):
res = rel.fetchall()
assert res == [(2, 2, 2)]

@pytest.mark.xfail(reason="Bug in DuckDB core (MRE at #19154)")
def test_same_name_cte(self, duckdb_cursor):
query = """
WITH df AS (
Expand Down Expand Up @@ -417,8 +418,8 @@ def test_cte_at_different_levels(self, duckdb_cursor):
WITH cte1 AS (
SELECT * FROM df
)
SELECT
cte1.*,
SELECT
cte1.*,
cte2.a AS cte2_a,
subquery.a AS cte3_a
FROM cte1
Expand All @@ -434,8 +435,8 @@ def test_cte_at_different_levels(self, duckdb_cursor):
SELECT * FROM df
WHERE a < 3
)
SELECT
df.*,
SELECT
df.*,
cte3.a AS cte3_a
FROM (
SELECT * FROM df
Expand Down