Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions patch/0030-init-sort-progress.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From 5f3e4a2015f9898ad7cfc77300b65779640f1fad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?MVS <[email protected]>
Date: Sun, 6 Oct 2025 09:30:00 +0200
Subject: [PATCH] init-sort-progress

Initialize uninitialized member variables in SortGlobalSinkState to fix valgrind warnings.

---
src/duckdb/src/common/sorting/sort.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/duckdb/src/common/sorting/sort.cpp b/src/duckdb/src/common/sorting/sort.cpp
index 2f5463e3f..1a8570451 100644
--- a/src/duckdb/src/common/sorting/sort.cpp
+++ b/src/duckdb/src/common/sorting/sort.cpp
@@ -17,7 +17,8 @@ namespace duckdb {
class SortGlobalSinkState : public GlobalSinkState {
public:
SortGlobalSinkState(ClientContext &context)
- : table(context, vector<LogicalType>(), CreateInitialSortState()) {
+ : GlobalSinkState(), table(context, vector<LogicalType>(), CreateInitialSortState()),
+ sorted_blocks(), sorted_blocks_temp() {
}

void AddLocalState(ExecutionContext &context, LocalSinkState &lstate_p);
--
2.34.1
26 changes: 26 additions & 0 deletions patch/0031-fix-rfuns-binary-type-assert.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
From 6a4e5b3025f9898ad7cfc77300b65779640f1fad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?MVS <[email protected]>
Date: Sun, 6 Oct 2025 09:35:00 +0200
Subject: [PATCH] fix-rfuns-binary-type-assert

Fix BinaryTypeAssert template function to use correct type parameter for right vector validation.

---
src/duckdb/extension/core_functions/include/rfuns_extension.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/duckdb/extension/core_functions/include/rfuns_extension.hpp b/src/duckdb/extension/core_functions/include/rfuns_extension.hpp
index 2f5463e3f..1a8570451 100644
--- a/src/duckdb/extension/core_functions/include/rfuns_extension.hpp
+++ b/src/duckdb/extension/core_functions/include/rfuns_extension.hpp
@@ -44,7 +44,7 @@ BinaryChunk BinaryTypeAssert(DataChunk &args) {
D_ASSERT(lefts.GetType() == LHS_LOGICAL_TYPE);

auto &rights = args.data[1];
- D_ASSERT(rights.GetType() == LHS_LOGICAL_TYPE);
+ D_ASSERT(rights.GetType() == RHS_LOGICAL_TYPE);

return {lefts, rights};
}
--
2.34.1
2 changes: 1 addition & 1 deletion src/include/rfuns_extension.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ BinaryChunk BinaryTypeAssert(DataChunk &args) {
D_ASSERT(lefts.GetType() == LHS_LOGICAL_TYPE);

auto &rights = args.data[1];
D_ASSERT(rights.GetType() == LHS_LOGICAL_TYPE);
D_ASSERT(rights.GetType() == RHS_LOGICAL_TYPE);

return {lefts, rights};
}
Expand Down
1 change: 1 addition & 0 deletions src/reltoaltrep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ struct AltrepRownamesWrapper {

AltrepRownamesWrapper(duckdb::shared_ptr<AltrepRelationWrapper> rel_p) : rel(rel_p) {
rowlen_data[0] = NA_INTEGER;
rowlen_data[1] = 0;
}

static AltrepRownamesWrapper *Get(SEXP x) {
Expand Down