Skip to content

Commit 7195282

Browse files
authored
enable union test (#340)
Blocked by #336
2 parents efeec66 + a161902 commit 7195282

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

crates/duckdb/src/test_all_types.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ fn test_large_arrow_types() -> crate::Result<()> {
2020
}
2121

2222
fn test_with_database(database: &Connection) -> crate::Result<()> {
23-
// uhugeint, time_tz, and dec38_10 aren't supported in the duckdb arrow layer
24-
// union is currently blocked by https://github.com/duckdb/duckdb/pull/11326
25-
let excluded = ["uhugeint", "time_tz", "dec38_10", "union", "varint"];
23+
// uhugeint, time_tz, varint, and dec38_10 aren't supported in the duckdb arrow layer
24+
let excluded = ["uhugeint", "time_tz", "dec38_10", "varint"];
2625

2726
let mut binding = database.prepare(&format!(
2827
"SELECT * EXCLUDE ({}) FROM test_all_types()",

crates/duckdb/src/types/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ impl From<&DataType> for Type {
142142
.collect(),
143143
),
144144
DataType::LargeList(inner) => Self::List(Box::new(Self::from(inner.data_type()))),
145-
// DataType::Union(_, _) => Self::Union,
145+
DataType::Union(_, _) => Self::Union,
146146
DataType::Decimal128(..) => Self::Decimal,
147147
DataType::Decimal256(..) => Self::Decimal,
148148
DataType::Map(field, ..) => {

0 commit comments

Comments
 (0)