Merge pull request #17 from wangfenjin/timestamp

impl date32 and timestamp

Author: wangfenjin

.github/workflows/rust.yaml

@@ -36,13 +36,13 @@ jobs:
           targets: ${{ matrix.target }}
           components: 'rustfmt, clippy'
       - run: cargo fmt --all -- --check
-      - run: cargo clippy --all-targets --workspace --features bundled -- -D warnings -A clippy::redundant-closure
+      - run: cargo clippy --all-targets --workspace --features bundled --features modern-full -- -D warnings -A clippy::redundant-closure
       - name: Run cargo-tarpaulin
         uses: actions-rs/[email protected]
         with:
           # Intentionally omit time feature until we're on time 0.3, at which
           # point it should be added to `bundled-full`.
-          args: '--features "bundled" --avoid-cfg-tarpaulin' # TODO restore to normal (https://github.com/xd009642/tarpaulin/issues/756#issuecomment-838769320)
+          args: '--features "bundled" --features "modern-full" --avoid-cfg-tarpaulin' # TODO restore to normal (https://github.com/xd009642/tarpaulin/issues/756#issuecomment-838769320)
       - name: Upload to codecov.io
         uses: codecov/codecov-action@v1
 
@@ -67,4 +67,4 @@ jobs:
           # leak sanitization, but we don't care about backtraces here, so long
           # as the other tests have them.
           RUST_BACKTRACE: "0"
-        run: cargo -Z build-std test --features 'bundled' --target x86_64-unknown-linux-gnu
+        run: cargo -Z build-std test --features 'bundled' --features 'modern-full' --target x86_64-unknown-linux-gnu

Cargo.toml

@@ -21,9 +21,12 @@ name = "duckdb"
 members = ["libduckdb-sys"]
 
 [features]
+default = ["modern-full"]
 bundled = ["libduckdb-sys/bundled"]
 buildtime_bindgen = ["libduckdb-sys/buildtime_bindgen"]
-default = []
+modern-full = [
+    "chrono",
+]
 
 [dependencies]
 time = { version = "0.3", optional = true }

Makefile

@@ -7,5 +7,5 @@ DUCKDB_LIB_DIR = /Users/wangfenjin/duckdb
 DUCKDB_INCLUDE_DIR = /Users/wangfenjin/duckdb
 
 all:
-	cargo test --features buildtime_bindgen -- --nocapture
-	cargo clippy --all-targets --workspace --features buildtime_bindgen -- -D warnings -A clippy::redundant-closure
+	cargo test --features buildtime_bindgen --features modern-full -- --nocapture
+	cargo clippy --all-targets --workspace --features buildtime_bindgen --features modern-full -- -D warnings -A clippy::redundant-closure

add_rustfmt_hook.sh

@@ -10,12 +10,15 @@ command -v rustfmt >/dev/null 2>&1 || { echo >&2 "Rustfmt is required but it's n
 cat > .git/hooks/pre-commit <<'EOF'
 #!/bin/bash -e
 declare -a rust_files=()
-files=$(git diff-index --name-only HEAD)
+files=$(git diff-index --name-only --cached HEAD)
 echo 'Formatting source files'
 for file in $files; do
     if [ ! -f "${file}" ]; then
         continue
     fi
+    if [ "${file}" -eq 'libduckdb-sys/duckdb/bindgen_bundled_version.rs' ]; then
+        continue
+    fi
     if [[ "${file}" == *.rs ]]; then
         rust_files+=("${file}")
     fi

libduckdb-sys/bindgen.sh

@@ -24,7 +24,7 @@ env LIBDUCKDB_SYS_BUNDLING=1 cargo test --features "bundled buildtime_bindgen"
 find "$SCRIPT_DIR/../target" -type f -name bindgen.rs -exec cp {} "$DUCKDB_LIB_DIR/bindgen_bundled_version.rs" \;
 
 # Sanity checks
-cd "$SCRIPT_DIR/.." || { echo "fatal error" >&2; exit 1; }
-cargo update
-cargo test --features "bundled buildtime_bindgen"
-printf '    \e[35;1mFinished\e[0m bundled DUCKDB tests\n'
+# cd "$SCRIPT_DIR/.." || { echo "fatal error" >&2; exit 1; }
+# cargo update
+# cargo test --features "bundled buildtime_bindgen"
+# printf '    \e[35;1mFinished\e[0m bundled DUCKDB tests\n'