Skip to content

Fix arrow list type to duckdb logical type conversion #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2025
Merged

Fix arrow list type to duckdb logical type conversion #574

merged 4 commits into from
Aug 21, 2025

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Aug 8, 2025 •
edited
Loading

When registering a scalar function which returns a list value, duckdb returns an error:

thread '<unnamed>' panicked at src/lib.rs:31:10:
Failed to register split_words function: DuckDBFailure(Error { code: Unknown, extended_code: 1 }, None)

This PR fixes this issue by replacing LogicalTypeId::try_from(..).into() by to_duckdb_logical_type.

mlafeldt
mlafeldt approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@mlafeldt mlafeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

I only had to fix a minor clippy issue.

@mlafeldt mlafeldt merged commit f5a687c into duckdb:main Aug 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlafeldt mlafeldt mlafeldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangrunji0408 @mlafeldt