Remove pointer indirection during init #610
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the pointer indirection in `duckdb_extension_access.get_database`. It is expected that the definition of `duckdb_extension_access` will be updated automatically after `duckdb.h` is updated (not sure if manual changes are needed there). Engine PR: duckdb/duckdb#19529
|
@mlafeldt when you have a chance, perhaps you can see more manual changes needed on Rust side? Meanwhile moving the PR to draft until the duckdb/duckdb#19529 is merged and updated |
|
Let's worry about this if/once duckdb/duckdb#19529 is merged. 👍 Then we can pull in header/binding changes from the next DuckDB release to make this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pointer indirection in
duckdb_extension_access.get_database. It is expected that the definition ofduckdb_extension_accesswill be updated automatically afterduckdb.his updated (not sure if manual changes are needed there).Engine PR: duckdb/duckdb#19529