Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hey team!
The tidy-check job's extension build can fail because the required dependencies are not retrieved by VCPKG. This problem is described by #223.
Changes
I've copied the
Setup vcpkgstep from the_extension_distribution.ymlworkflow into the_extension_code_quality.ymlworkflow. Thus, VCPKG is now installed prior to the extension build.Furthermore, I've updated the
tidy-checkMakefile target to include VCPKG in the build process. For that I've taken inspiration from the Makefile's debug target.Result
Using these changes my tidy-check now successfully builds the extension (including its dependencies).
Before: https://github.com/Noorts/PDXearch/actions/runs/21448678175/job/61771370390
After: https://github.com/Noorts/PDXearch/actions/runs/21448728200/job/61771541738.
Remaining Concerns
I've included
USE_MERGED_VCPKG_MANIFEST, but I'm not familiar with the feature and haven't tested it. It would be nice to confirm that the approach is correct, or to change it as necessary.