Parse event path file to enable reduced CI mode#323
Merged
carlopi merged 3 commits intoduckdb:mainfrom Feb 19, 2026
Merged
Conversation
carlopi
reviewed
Feb 19, 2026
| return githubEventPush, nil | ||
| } | ||
|
|
||
| return githubEventUnknown, nil |
Collaborator
There was a problem hiding this comment.
I think the logic here it's a bit too simple.
I would prefer either to remove the
if _, ok := payload["ref"]; ok {
return githubEventPush, nil
}
section, since that not used AND looks wrong to me (I guess ref it's present in more cases that a push).
More in general, could you compile a list of different situation where this code might be reached? And then we can map what default behaviour we would like to see in the different situations?
carlopi
approved these changes
Feb 19, 2026
Collaborator
carlopi
left a comment
There was a problem hiding this comment.
Thanks!
There are a couple of things that would be handy to clean-up before going live:
- fixup TestCITools
- discuss detection of events (in particular detection of
push) - discuss how to be more robust to unseen changes in webhook (more e2e test)
lnkuiper
added a commit
to duckdb/duckdb
that referenced
this pull request
Feb 23, 2026
This is a follow-up PR for the extensions CI tools [PR](duckdb/extension-ci-tools#323). It removes the hardcoded list of excluded duckdb_archs by relying on the `reduced_ci_mode` logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Detect GitHub event type
The environment variable
GITHUB_EVENT_NAMEis missing inside a reusable workflow file. We can use the github event path file to derive this event name value.The event path file is the path to the file on the runner that contains the full event webhook payload. For example,
/github/workflow/event.json.If the environment variable
GITHUB_EVENT_PATHis missing, the detected event type becomesunknown.If the key
pull_requestis found in the github event path file, the detected event type becomespull_request.Else, if the key
refis found in the github event path file, the detected event type becomespush.Enable reduced CI mode if auto and PR
When the initial reduced CI mode is
autoor empty, and the detected event type ispull_request, change the reduced CI mode toenabled.CLI log messages
I added a simple console log handler that help diagnosing what values changed.
For example, locally, I see these messages:
because the event path is missing and thus
event_typebecomesunknown.In CI, I can see these messages for this pull request: