Skip to content

Commit 0e6e734

Browse files
authored
Rename and improve Duck Player tests (#6386)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207252092703676/task/1210787158998860?focus=true ### Description * Mark `ask_direct_youtube_duckplayer.yaml` as `duckplayerlocal` * Use common assertion flows in: * `ask_direct_youtube_youtube.yaml` * `direct_duckplayer.yaml` * `never_youtube.yaml` * Rename `youtube_overlay_use_duckplayer.yaml` to `ask_direct_youtube_duckplayer.yaml` * Remove old `ask_direct_youtube_duckplayer.yaml` as it was loading Duck Player directly instead, which was already implemented in `direct_duckplayer_youtube.yaml` ### Steps to test this PR - Check tests marked as `duckplayer` run in Maestro Cloud - Check tests marked as `duckplayerlocal` run locally
1 parent 6b0b243 commit 0e6e734

6 files changed

+7
-70
lines changed
Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
appId: com.duckduckgo.mobile.android
22
name: "DuckPlayer: Ask > Direct YouTube > Duck Player"
33
tags:
4-
- duckplayer
4+
- duckplayerlocal
55
---
66
- retry:
77
maxRetries: 3
@@ -10,22 +10,9 @@ tags:
1010
clearState: true
1111

1212
- runFlow: ../shared/skip_all_onboarding.yaml
13+
- runFlow: common/load_youtube_video.yaml
1314

1415
- tapOn:
15-
id: "omnibarTextInput"
16-
- inputText: "duck://player/3ml7yeKBUhc"
17-
- pressKey: Enter
16+
text: "Turn On Duck Player"
1817

19-
- extendedWaitUntil:
20-
visible:
21-
text: "duck://player/3ml7yeKBUhc.*"
22-
timeout: 5000
23-
24-
- tapOn:
25-
id: app
26-
27-
- tapOn:
28-
text: "Watch on YouTube"
29-
30-
- runFlow: common/assert_youtube_visible.yaml
31-
- runFlow: common/assert_overlay_not_shown.yaml
18+
- runFlow: common/assert_duckplayer_visible.yaml

.maestro/duckplayer/ask_direct_youtube_youtube.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,4 @@ tags:
2222
text: "Turn on Duck Player to watch without targeted ads"
2323
timeout: 5000
2424

25-
# Core assertion: Verify we're still on regular YouTube (not Duck Player)
26-
- assertNotVisible:
27-
text: "duck://player/.*"
28-
29-
# Verify we're still on YouTube mobile URL
30-
- assertVisible:
31-
text: ".*youtube.*"
25+
- runFlow: common/assert_youtube_visible.yaml

.maestro/duckplayer/direct_duckplayer.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,4 @@ tags:
1616
- inputText: "duck://player/3ml7yeKBUhc"
1717
- pressKey: Enter
1818

19-
- extendedWaitUntil:
20-
visible:
21-
text: "duck://player/3ml7yeKBUhc"
22-
timeout: 5000
23-
24-
- assertNotVisible:
25-
text: ".*youtube.com/watch.*"
19+
- runFlow: common/assert_duckplayer_visible.yaml

.maestro/duckplayer/never_youtube.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,4 @@ tags:
2828
- assertNotVisible:
2929
text: "duck://player/.*"
3030

31-
# Verify we're still on YouTube mobile URL
32-
- assertVisible:
33-
text: ".*youtube.*"
34-
35-
- runFlow: common/assert_overlay_not_shown.yaml
31+
- runFlow: common/assert_youtube_visible.yaml

.maestro/duckplayer/youtube_overlay_use_duckplayer.yaml

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)