[WIP] Use Spotless for Kotlin formatting #6420

mikescamell · 2025-07-18T14:28:36Z

Task/Issue URL:

Description

WIP until Spotless gets worktree support diffplug/spotless#2375

Steps to test this PR

Feature 1

[ ]
[ ]

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

.github/workflows/ci.yml

daxmobile · 2025-07-18T14:28:55Z

.github/workflows/ci.yml

🚫 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2002:style:1:5: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead [shellcheck]

Android/.github/workflows/ci.yml

Line 189 in 33a5226

run: cat build/fladle/fladleResults/HtmlErrorReport.html | cut -d\` -f2 >> results.json

.github/workflows/nightly.yml

ratchetFrom means Spotless will apply only to files which have changed since origin/main It also means we need to make some changes to CI due to ensure builds pass due to shallow clones. See https://github.com/diffplug/spotless/tree/main/plugin-gradle#using-ratchetfrom-on-ci-systems for more details.

Spotless breaks because we have classes and files that have been commited that should technically be ignored by our .gitignore settings. See diffplug/spotless#911 (comment) Therefore we have to either remove these files or move them. In this case the DeviceShield stuff was in a package called "report" which we ignore in .gitignore. Therefore I gave it a new package name We want to keep the icon and I guess we want to keep the copyright folder so I made that work in .gitignore

As these have "changed" since develop then they need formatting!

mikescamell changed the title ~~Use Spotless for Kotlin formatting~~ [WIP] Use Spotless for Kotlin formatting Jul 18, 2025