Branch for all changes related to widgets. We cannot use feature flags. #6572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
anikiki
force-pushed
the
feature/ana/add_duck_ai_entry_points_to_widgets_plus_additional_widgets
branch
from
4f9b5e7 to
6906ff5
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/276630244458377/task/1210378258410691?focus=true ### Description This PR updates the search widget to include Duck.ai functionality by: - Adding a new Duck.ai icon to the search widget - Replacing RelativeLayout with LinearLayout for better control of widget elements - Creating a SearchWidgetConfigurator to handle widget configuration based on feature availability - Adding a vertical separator between voice search and Duck.ai icons - Implementing a broadcast receiver to update widgets when Duck.ai becomes available - Increasing corner radius for the widget background for a more modern look - Updating the search icon to a 24dp version for better visual consistency - Adjusting padding and layout dimensions for improved appearance ### Steps to test this PR _Widget UI Updates_ - [ ] Verify the Simple Search Widget Light and the Simple Search Widget Dark look as in [Figma](https://www.figma.com/design/BOHDESHODUXK7wSRNBOHdu/%F0%9F%A4%96-Android-Components?node-id=18680-16262&m=dev). - [ ] Verify the Simple Search Widget Light and the Simple Search Widget Dark behave as expected. See test cases in [Asana](https://app.asana.com/1/137249556945/project/276630244458377/task/1211064092310635?focus=true). ### UI changes See [Asana Task](https://app.asana.com/1/137249556945/task/1210378258410691?focus=true). --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210378258410691
…idgets_plus_additional_widgets
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200581511062568/task/1211103096551754?focus=true ### Description Refactored the DuckChat widget integration to simplify the process of opening DuckChat from the search widget. Removed the `createDuckChatIntent()` method from the DuckChat interface and implementation, replacing it with a more direct approach that uses `BrowserActivity.intent()` with an `openDuckChat` parameter. ### Steps to test this PR Code review. ### NO UI changes
Task/Issue URL: https://app.asana.com/1/137249556945/task/1210543550382441?focus=true ### Description Updated the UI for Search and Favorites widget. ### Steps to test this PR See https://app.asana.com/1/137249556945/project/1200581511062568/task/1211148541512426?focus=true ### UI changes See screenshots in https://app.asana.com/1/137249556945/task/1210543550382441?focus=true
…idgets_plus_additional_widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/715106103902962/task/1211036141742774?focus=true
Description
This branch will eventually contain all changes to widgets + new widgets.
We want to merge to develop only after all changes are implemented.
Steps to test this PR
All tests will be conducted in individual PRs.
UI changes
All UI changes will be shown in individual PRs.