[Implementation] Widget 1: Search + Duck.ai #6576

anikiki · 2025-08-13T17:14:50Z

Task/Issue URL: https://app.asana.com/1/137249556945/project/276630244458377/task/1210378258410691?focus=true

Description

This PR updates the search widget to include Duck.ai functionality by:

Adding a new Duck.ai icon to the search widget
Replacing RelativeLayout with LinearLayout for better control of widget elements
Creating a SearchWidgetConfigurator to handle widget configuration based on feature availability
Adding a vertical separator between voice search and Duck.ai icons
Implementing a broadcast receiver to update widgets when Duck.ai becomes available
Increasing corner radius for the widget background for a more modern look
Updating the search icon to a 24dp version for better visual consistency
Adjusting padding and layout dimensions for improved appearance

Steps to test this PR

Widget UI Updates

Verify the Simple Search Widget Light and the Simple Search Widget Dark look as in Figma.
Verify the Simple Search Widget Light and the Simple Search Widget Dark behave as expected. See test cases in Asana.

UI changes

See Asana Task.

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1210378258410691

anikiki · 2025-08-13T17:15:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

[Implementation] Widget 1: Search + Duck.ai #6576 👈 (View in Graphite)
Branch for all changes related to widgets. We cannot use feature flags. #6572
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

anikiki · 2025-08-15T11:13:17Z

app/src/androidTest/java/com/duckduckgo/widget/SearchAndFavoritesGridCalculatorKtTest.kt

                    TestCase(3, 465),
-                    TestCase(4, 466),
+                    TestCase(3, 466),


We changed some of the dimens, so I updated the test to match the current expected behavior.

anikiki · 2025-08-15T11:14:30Z

app/src/main/java/com/duckduckgo/widget/SearchWidget.kt


        val views = RemoteViews(context.packageName, layoutId)
-        views.setViewVisibility(R.id.searchInputBox, if (shouldShowHint) View.VISIBLE else View.INVISIBLE)


Removed all this as in the new requirements we don't hide the hint.

anikiki · 2025-08-15T11:15:21Z

app/src/main/res/xml/search_widget_info.xml

@@ -20,7 +20,7 @@
 <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android"
    android:initialKeyguardLayout="@layout/search_widget_dark"
    android:initialLayout="@layout/search_widget_dark"
-    android:minWidth="314dp"
+    android:minWidth="250dp"


New requirements.

anikiki · 2025-08-15T11:15:32Z

app/src/main/res/xml/search_widget_info_light.xml

@@ -20,7 +20,7 @@
 <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android"
    android:initialKeyguardLayout="@layout/search_widget_light"
    android:initialLayout="@layout/search_widget_light"
-    android:minWidth="314dp"
+    android:minWidth="250dp"


New requirements.

anikiki · 2025-08-15T11:15:39Z

common/common-ui/src/main/res/values/design-system-dimensions.xml

@@ -141,7 +141,7 @@
    <dimen name="searchWidgetSearchBarSideMargin">16dp</dimen>
    <dimen name="searchWidgetFavoriteItemContainerWidth">64dp</dimen>
    <dimen name="searchWidgetFavoriteItemContainerHeight">78dp</dimen>
-    <dimen name="searchWidgetSearchBarHeight">46dp</dimen>
+    <dimen name="searchWidgetSearchBarHeight">48dp</dimen>


New requirements.

anikiki · 2025-08-15T11:16:28Z

duckchat/duckchat-api/src/main/java/com/duckduckgo/duckchat/api/DuckChat.kt

+     *
+     * @return Intent to open DuckChat.
+     */
+    fun openDuckChatIntent(): Intent?


Opened a proposal for the changes in this file.

Copilot

Pull Request Overview

This PR implements the first widget enhancement by integrating Duck.ai functionality into the search widget. The implementation replaces the RelativeLayout with LinearLayout for better control, adds Duck.ai and voice search icons with a separator, and includes dynamic configuration based on feature availability.

Key changes:

Widget layout restructure from RelativeLayout to LinearLayout with new Duck.ai icon and separator
SearchWidgetConfigurator class to handle dynamic widget configuration based on voice search and Duck.ai availability
Broadcast receiver system to update widgets when Duck.ai becomes available or settings change
Visual improvements including larger corner radius, updated icons, and better spacing

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`app/src/main/res/layout/search_widget_*.xml`	Layout restructure from RelativeLayout to LinearLayout with new Duck.ai icon, separator, and updated styling
`app/src/main/java/com/duckduckgo/widget/SearchWidgetConfigurator.kt`	New class handling dynamic widget configuration based on feature availability
`duckchat/duckchat-api/src/main/java/com/duckduckgo/duckchat/api/DuckChat.kt`	Added createDuckChatIntent() method and moved isDuckChatUserEnabled() from internal interface
`app/src/main/java/com/duckduckgo/widget/DuckAiSearchWidgetUpdaterReceiver.kt`	Broadcast receiver to update widgets when Duck.ai availability changes
`duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/repository/DuckChatFeatureRepository.kt`	Widget update broadcast on first Duck.ai usage

app/src/main/java/com/duckduckgo/widget/SearchWidgetConfigurator.kt

app/src/main/res/drawable/ic_vertical_separator_dark.xml

…implemented yet.

…idget configuration.

…operations and update widget visibility logic.

mikescamell · 2025-08-19T10:21:20Z

app/src/main/java/com/duckduckgo/widget/SearchWidgetConfigurator.kt

+    fun configureWidget(
+        context: Context,
+        remoteViews: RemoteViews,
+        appWidgetManager: AppWidgetManager,
+        appWidgetId: Int,
+        fromFavWidget: Boolean,
+    ) {
+        appCoroutineScope.launch(dispatcherProvider.io()) {


❓ Would it be better to follow structured concurrency principles and mark this function suspend instead of launching? That way the caller gets to decide the scope and lifecycle.

mikescamell

Nice work! LGTM

anikiki mentioned this pull request Aug 13, 2025

Branch for all changes related to widgets. We cannot use feature flags. #6572

Draft

anikiki changed the title ~~Added Duck.ai entry points to search widget and updated UI. No logic implemented yet.~~ [Implementation] Widget 1: Search + Duck.ai Aug 13, 2025

anikiki marked this pull request as ready for review August 15, 2025 11:12

anikiki requested review from malmstein and nalcalag as code owners August 15, 2025 11:12

anikiki commented Aug 15, 2025

View reviewed changes

anikiki assigned mikescamell Aug 15, 2025

anikiki requested review from mikescamell and Copilot August 15, 2025 11:48

Copilot AI reviewed Aug 15, 2025

View reviewed changes

app/src/main/java/com/duckduckgo/widget/SearchWidgetConfigurator.kt Show resolved Hide resolved

app/src/main/java/com/duckduckgo/widget/SearchWidgetConfigurator.kt Outdated Show resolved Hide resolved

app/src/main/res/drawable/ic_vertical_separator_dark.xml Show resolved Hide resolved

Added Duck.ai entry points to search widget and updated UI. No logic …

2c22a09

…implemented yet.

anikiki force-pushed the feature/ana/add_duck_ai_entry_points_to_widgets_plus_additional_widgets branch from 4f9b5e7 to 6906ff5 Compare August 15, 2025 11:54

anikiki force-pushed the feature/ana/implementation_widget_1_search_and_duck_ai branch from 40bb1d5 to 2c22a09 Compare August 15, 2025 11:54

anikiki added 2 commits August 18, 2025 11:13

Refactor DuckChat intent creation to be suspend function and update w…

ab131c0

…idget configuration.

Refactor SearchWidgetConfigurator to use coroutines for asynchronous …

758819d

…operations and update widget visibility logic.

mikescamell reviewed Aug 19, 2025

View reviewed changes

mikescamell approved these changes Aug 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Implementation] Widget 1: Search + Duck.ai #6576

[Implementation] Widget 1: Search + Duck.ai #6576

anikiki commented Aug 13, 2025 •

edited

Loading

Uh oh!

anikiki commented Aug 13, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

anikiki Aug 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikescamell Aug 19, 2025

Uh oh!

mikescamell left a comment

Uh oh!

Uh oh!


		val views = RemoteViews(context.packageName, layoutId)
		views.setViewVisibility(R.id.searchInputBox, if (shouldShowHint) View.VISIBLE else View.INVISIBLE)

[Implementation] Widget 1: Search + Duck.ai #6576

Are you sure you want to change the base?

[Implementation] Widget 1: Search + Duck.ai #6576

Conversation

anikiki commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

UI changes

Uh oh!

anikiki commented Aug 13, 2025

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

anikiki Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikescamell Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

mikescamell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anikiki commented Aug 13, 2025 •

edited

Loading