Onboarding Design Experiment: Final fixes

[mikescamell]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1211042630873651?focus=true

Description

This PR fixes several animation issues in the onboarding experience:

1. Added proper handling for hiding the Buck magnifying glass animation when showing DaxIntroSearchOptionsCta
2. Fixed the BB shield animating up as the text animation starts playing
3. Fixed a bug where click listeners were being set before animations completed
4. Improved animation cleanup when dialogs are dismissed to prevent memory leaks and visual glitches
5. Added proper text initialization for dialog titles to prevent flashing empty content
6. Ensured animations are properly canceled when clearing dialogs

Steps to test this PR

BB Fixes

• Verify the shield does not move up as the text animation plays on the initial onboarding screen

Buck Fixes

• Verify that the Buck magnifying glass animation properly hides when dismissing on new tabbing after "Try a Search"
• Confirm that click listeners on search and site suggestion options only activate after animations complete. Tap them when they are not visible.
• Test dialog dismissal to ensure all animations are properly cleaned up. This may or may not be consistent but is a best attempt.

UI changes

N/A

[Copilot]

Pull Request Overview

This PR addresses animation timing and cleanup issues in the onboarding experience to prevent visual glitches and improve user interaction reliability. The changes focus on proper animation sequencing and resource management.

Key changes:

• Fixed animation timing by ensuring click listeners are only set after animations complete
• Added proper animation cleanup and cancellation to prevent memory leaks
• Improved handling of Buck magnifying glass animation hiding

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
BbWelcomePage.kt	Initializes dialog title text to prevent empty content flashing
Cta.kt	Implements proper animation cleanup, tracks animators, and delays click listener setup
BrowserTabFragment.kt	Adds proper hiding of Buck magnifying glass animation for search options

---

_{You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}