Skip to content

Post visual update: Update the favorites item style #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Post visual update: Update the favorites item style #6599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d68b64
Update the favorites item style
0nko Aug 15, 2025
03ef382
Merge branch 'develop' into feature/ondrej/update-favorites-item
0nko Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/common-ui/src/main/res/drawable/background_dashed_outline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
android:dashWidth="4dp"
android:dashGap="4dp"
android:color="?attr/daxColorLines" />
<corners android:radius="@dimen/smallShapeCornerRadius" />
<corners android:radius="@dimen/mediumShapeCornerRadius" />
</shape>
12 changes: 7 additions & 5 deletions saved-sites/saved-sites-impl/src/main/res/layout/view_favourite_section_item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,17 @@
android:layout_height="@dimen/gridItemImageSize"
android:layout_gravity="center_horizontal"
app:cardBackgroundColor="?attr/daxColorSurface"
app:cardCornerRadius="@dimen/smallShapeCornerRadius"
app:cardCornerRadius="@dimen/mediumShapeCornerRadius"
tools:visibility="gone"
app:cardElevation="2dp">
app:cardElevation="0dp">

<ImageView
<com.google.android.material.imageview.ShapeableImageView
android:id="@+id/quickAccessFavicon"
android:layout_width="@dimen/gridItemImageSize"
android:layout_height="@dimen/gridItemImageSize"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:padding="@dimen/keyline_2"
android:layout_gravity="center"
app:shapeAppearanceOverlay="@style/Widget.DuckDuckGo.FavouritesItemFavicon"
android:importantForAccessibility="no" />

</com.google.android.material.card.MaterialCardView>
Expand Down
4 changes: 4 additions & 0 deletions saved-sites/saved-sites-impl/src/main/res/values/styles-saved-sites.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,8 @@
<item name="android:layout_height">match_parent</item>
<item name="isExpandable">true</item>
</style>
<style name="Widget.DuckDuckGo.FavouritesItemFavicon">
<item name="cornerFamily">rounded</item>
<item name="cornerSize">@dimen/smallShapeCornerRadius</item>
</style>
</resources>
Loading