Skip to content

Support message responses #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: cris/adsjs/support-messaging
Choose a base branch
from

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Aug 18, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1205008441501016/task/1211080061667204?focus=true

Description

Steps to test this PR

Feature enabled

  • Install C-S-S from jkt/adsjs-messaging
  • Enable useNewWebCompatApis under feature flag inventory (enabled by default)
  • Open https://w3c.github.io/web-share/demos/share-files.html
  • Click "Share"
  • Dismiss native share popup
  • Check message displayed: "Error sharing: Abort Error: Share canceled"

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging-responses branch from 8c73a37 to 5cb3f85 Compare August 19, 2025 09:46
@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging branch 2 times, most recently from e49f458 to cc13d8c Compare August 19, 2025 10:08
@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging-responses branch from 5cb3f85 to 4c29255 Compare August 19, 2025 10:08
@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging branch from cc13d8c to fbb826b Compare August 19, 2025 10:51
@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging-responses branch from 4c29255 to 62a417d Compare August 19, 2025 10:51
@CrisBarreiro CrisBarreiro force-pushed the cris/adsjs/support-messaging-responses branch from 62a417d to a405bd9 Compare August 19, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant