Skip to content

VPN: Add params to latency pixels #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

VPN: Add params to latency pixels #6607

merged 1 commit into from
Aug 19, 2025
+251 −0

Conversation

karlenDimla
Copy link
Contributor

@karlenDimla karlenDimla commented Aug 19, 2025 •
edited by landomen
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211020399411579?focus=true

Description

Adds a few params to the VPN latency pixels that could help us investigate / verify the cause of latency increase

Steps to test this PR

  • Filter Pixel url request: in your logcat
  • Enable VPN
  • Wait for around 5 seconds
  • Verify you see a _latency_ pixel.
  • Verify that that pixel contains the location and os15Above params.
  • Verify that other pixels don’t have the additional params

@karlenDimla Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@karlenDimla karlenDimla requested a review from aitorvs August 19, 2025 09:51
@karlenDimla karlenDimla removed the request for review from aitorvs August 19, 2025 09:52
@landomen landomen self-requested a review August 19, 2025 11:28
@landomen landomen self-assigned this Aug 19, 2025
landomen
landomen approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@landomen landomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@karlenDimla karlenDimla merged commit 205e592 into develop Aug 19, 2025
18 checks passed
@karlenDimla karlenDimla deleted the feature/karl/vpn/latency-os-param branch August 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landomen landomen landomen approved these changes

Assignees

@landomen landomen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlenDimla @landomen @aitorvs