Skip to content

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Sep 22, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211427307407593?focus=true

Description

  • Implement API proposal to simplify using AddDocumentStartJavaScript
  • Add AI rules for doc-bot

Steps to test this PR

Pre-requisites

  • Apply patch
  • Fresh install app
  • Filter logs by "Cris"

Check script injected correctly

Check messaging works as expected

  • Load a site
  • Check logs for a message with "featureName":"messaging","context":"contentScopeScripts"
  • Open the context menu
  • Check logs for {"context":"contentScopeScripts","featureName":"breakageReporting","params":{},"subscriptionName":"getBreakageReportValues"}

Check plugin created only once per tab

  • Create a new tab
  • Check logs for Creating plugin
  • Load a site
  • Check no new logs for Creating plugin
  • Open tab switcher
  • Go back to the same tab
  • Check no new logs for Creating plugin
  • Create a new tab
  • Check there's a new log for Creating plugin

UI changes

n/a

Copy link
Contributor Author

CrisBarreiro commented Sep 22, 2025

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch 4 times, most recently from 6cff872 to 6362f3e Compare September 24, 2025 15:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch 4 times, most recently from ca214eb to fcf08e1 Compare October 2, 2025 09:54
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from 93f3812 to 19a98b9 Compare October 3, 2025 09:53
@CrisBarreiro CrisBarreiro marked this pull request as ready for review October 3, 2025 10:12
@CrisBarreiro CrisBarreiro requested a review from CDRussell October 3, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant