-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add delegate to simplify creating implementations of WebMessagingPlugin #6830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CrisBarreiro
wants to merge
9
commits into
feature/cris/add-document-start-javascript-injector-delegate
Choose a base branch
from
feature/cris/web-messaging-delegate
base: feature/cris/add-document-start-javascript-injector-delegate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9f4f23c
to
c90de9d
Compare
27eb1c3
to
97e0aa3
Compare
3bc570a
to
2ae7c9b
Compare
bbf78b3
to
f6269d5
Compare
0222457
to
21a133d
Compare
6cff872
to
6362f3e
Compare
21a133d
to
f425b01
Compare
f425b01
to
7a31d58
Compare
6362f3e
to
9c5603e
Compare
7a31d58
to
3a8789c
Compare
e5f4f80
to
ca214eb
Compare
bdd6da2
to
035bbf5
Compare
ca214eb
to
fcf08e1
Compare
6d1eddc
to
6f99b38
Compare
6f99b38
to
d6aab83
Compare
93f3812
to
19a98b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211531154160730?focus=true
Description
WebMessageDelegate
to simplify working withWebMessaging
. See proposalSteps to test this PR
Pre-requisites
"Cris"
Check script injected correctly
Check messaging works as expected
"featureName":"messaging","context":"contentScopeScripts"
{"context":"contentScopeScripts","featureName":"breakageReporting","params":{},"subscriptionName":"getBreakageReportValues"}
Check plugin created only once per tab
Creating plugin
andCreating messaging plugin
Creating plugin
orCreating messaging plugin
Creating plugin
orCreating messaging plugin
Creating plugin
andCreating messaging plugin
UI changes
n/a