Skip to content

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Sep 22, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211531154160730?focus=true

Description

  • Add WebMessageDelegate to simplify working with WebMessaging. See proposal
  • Add AI rules for doc-bot

Steps to test this PR

Pre-requisites

  • Apply patch
  • Fresh install app
  • Filter logs by "Cris"

Check script injected correctly

Check messaging works as expected

  • Load a site
  • Check logs for a message with "featureName":"messaging","context":"contentScopeScripts"
  • Open the context menu
  • Check logs for {"context":"contentScopeScripts","featureName":"breakageReporting","params":{},"subscriptionName":"getBreakageReportValues"}

Check plugin created only once per tab

  • Create a new tab
  • Check logs for Creating plugin and Creating messaging plugin
  • Load a site
  • Check no new logs for Creating plugin or Creating messaging plugin
  • Open tab switcher
  • Go back to the same tab
  • Check no new logs for Creating plugin or Creating messaging plugin
  • Create a new tab
  • Check there's a new log for Creating plugin and Creating messaging plugin

UI changes

n/a

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch 2 times, most recently from 9f4f23c to c90de9d Compare September 23, 2025 10:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from 27eb1c3 to 97e0aa3 Compare September 23, 2025 11:28
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch 2 times, most recently from 3bc570a to 2ae7c9b Compare September 23, 2025 15:16
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from bbf78b3 to f6269d5 Compare September 23, 2025 15:22
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch 2 times, most recently from 0222457 to 21a133d Compare September 24, 2025 15:21
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch 2 times, most recently from 6cff872 to 6362f3e Compare September 24, 2025 15:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch from 21a133d to f425b01 Compare September 24, 2025 15:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch from f425b01 to 7a31d58 Compare October 1, 2025 16:22
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from 6362f3e to 9c5603e Compare October 1, 2025 16:22
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch from 7a31d58 to 3a8789c Compare October 1, 2025 16:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch 2 times, most recently from e5f4f80 to ca214eb Compare October 2, 2025 08:06
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch 2 times, most recently from bdd6da2 to 035bbf5 Compare October 2, 2025 09:54
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from ca214eb to fcf08e1 Compare October 2, 2025 09:54
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch 5 times, most recently from 6d1eddc to 6f99b38 Compare October 2, 2025 15:04
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/web-messaging-delegate branch from 6f99b38 to d6aab83 Compare October 3, 2025 09:53
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/add-document-start-javascript-injector-delegate branch from 93f3812 to 19a98b9 Compare October 3, 2025 09:53
@CrisBarreiro CrisBarreiro marked this pull request as ready for review October 3, 2025 11:14
@CrisBarreiro CrisBarreiro requested a review from CDRussell October 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant