Skip to content

Conversation

mihf05
Copy link

@mihf05 mihf05 commented Oct 5, 2025

Description

Fixes #6702 - Tab switcher '...' menu is invisible

The issue was that the popup menu button was only having its isEnabled property set, but not its isVisible property. On some Android devices and different Android versions/themes, disabled menu items can become invisible or very faint, which caused the menu to not appear on real devices while still being visible on virtual devices.

Changes Made

  • Explicitly set isVisible = true for the popup menu toolbar button in TabSwitcherMenuExt.kt
  • Added comment explaining the fix for future reference
  • Ensured the menu button is always visible regardless of enabled state

Testing

The fix addresses the root cause by ensuring the menu button visibility is explicitly controlled, which should resolve the difference in behavior between virtual and real devices.

Root Cause Analysis

The issue occurred because:

  1. The menu button was only having isEnabled set based on dynamicMenu.isMenuButtonEnabled
  2. Different Android devices/versions handle disabled menu items differently - some make them invisible or very faint
  3. Virtual devices may use a different theme or rendering that keeps disabled items visible
  4. Real devices were applying system-level theming that hid disabled menu items

This fix ensures consistent behavior across all devices by explicitly controlling visibility.

mihf05 and others added 3 commits October 6, 2025 01:29
Fixes duckduckgo#6702 - Tab switcher '...' menu is invisible

The issue was that the popup menu button was only having its isEnabled
property set, but not its isVisible property. On some Android devices
and different Android versions/themes, disabled menu items can become
invisible or very faint, which caused the menu to not appear on real
devices while still being visible on virtual devices.

This fix ensures the popup menu button is always visible by explicitly
setting isVisible = true, regardless of the enabled state.

- Set explicit visibility for popup menu toolbar button
- Add comment explaining the fix for future reference
…-b277f6c81ac5

Fix tab switcher menu button visibility on real devices
@mihf05
Copy link
Author

mihf05 commented Oct 8, 2025

Hi maintainers! 👋

This PR fixes issue #6702 - Tab switcher '...' menu is invisible on real devices.

Quick Summary:

  • This is a simple visibility fix that addresses device-specific rendering differences
  • The root cause was that disabled menu items are handled differently across Android devices/versions
  • Virtual devices kept disabled items visible, but real devices made them invisible/faint
  • The fix explicitly sets isVisible = true to ensure consistent behavior

Ready for Review:
Could someone please approve the workflow runs and review this fix? It's a straightforward change that should resolve the reported issue.

Thanks! 🙏

Fixes #6702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tab switcher '...' menu is invisible
1 participant