-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding search related attributed metrics #6899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/cristian/attributed_metrics_internal_dev_settings
Are you sure you want to change the base?
Adding search related attributed metrics #6899
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
831e0ec
to
c8c63fb
Compare
12d236a
to
6a65b73
Compare
2106b08
to
bedf6b7
Compare
6a65b73
to
6129721
Compare
bedf6b7
to
5fd75af
Compare
6129721
to
83ab535
Compare
5fd75af
to
6a6bd27
Compare
83ab535
to
4738c79
Compare
4738c79
to
e0ba965
Compare
store.searchRetentionAtb?.let { | ||
store.searchRetentionAtb = binding.searchAtb.text | ||
} | ||
store.searchRetentionAtb = binding.searchAtb.text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal screen bug fix: before making a search, there's no search retention atb, and override was not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File only contains logging changes, to improve testing.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175158?focus=true
and: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175159?focus=true
Description
Introduces 2 attributed metrics and their initial implementation.
Steps to test this PR
While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"
Note: Test cases should be executed in order
Not enough data
Client status running: true -> isActive: true, isEnabled: true
Attributed Metrics Dev Settings
v502-1
(and click save)Skip emitting...not enough data or no events
(bothddg_search_days
andddg_search
)Sending data
Attributed Metrics Dev Settings
v502-1
(and click save)Fired pixel user_average_searches_past_week_first_month with params {count=0}
(Note: 0 is the bucket, not value. Notice first_month in pixel name)Fired pixel user_active_past_week with params {days=2}
(note: 2 is the bucket, not the value)Trigger only if search atb refreshes
Skip emitting....atb not changed
(bothddg_search_days
andddg_search
)ddg_search_days
andddg_search
)installation >1mo ago
Attributed Metrics Dev Settings
v502-1
(and click save)Fired pixel user_average_searches_past_week with params {count=0}
(Note: 0 is the bucket, not value. Notice this is not first_month)Fired pixel user_active_past_week with params {days=2}
(note: 2 is the bucket, not the value)Client not active
Client status running: false -> isActive: false, isEnabled: true
Discard collect event....client not active
and not emittedSkip emitting....
UI changes