Add attributed metrics internal dev settings #6901
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cmonfortep
force-pushed
the
feature/cristian/attributed_metrics_internal_dev_settings
branch
2 times, most recently
from
bedf6b7 to
5fd75af
Compare
| import java.util.* | ||
| import javax.inject.Inject | ||
|
|
||
| @InjectWith(ViewScope::class) |
There was a problem hiding this comment.
I'm gonna guess these 2 files and the layout are here rather than in the attributed internal module because some dependencies are within the app module?
There was a problem hiding this comment.
Correct, there's some stored data that belongs to other modules and our logic depends on those values. So allowing other modules to include internal views here. I was about to create an statistics-internal setting, but some data also belongs to :app module, and it was too much to create several new settings.
cmonfortep
force-pushed
the
feature/cristian/attributed_metrics_module
branch
from
0602cd7 to
1e2a8db
Compare
cmonfortep
force-pushed
the
feature/cristian/attributed_metrics_internal_dev_settings
branch
from
5fd75af to
6a6bd27
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211578504512146?focus=true
Description
Includes a dev setting screen for testing purposes. It will allow you to:
Steps to test this PR
Feature 1
UI changes