Skip to content

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Oct 8, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211578851788392?focus=true

Description

  • FF updating script on protections changed as part of native crashes investigation after adding addDocumentStartJavaScript

Steps to test this PR

Pre-requisites

  • Apply this patch
  • Do a clean install of the app
  • Open Feature flags inventory
  • Set updateScriptOnPageFinished to false to reduce the amount of logs
  • Filter logcat by "Cris"

FF enabled

  • Open Feature flags inventory
  • Set updateScriptOnProtectionsChanged to true
  • Load a page
  • Change protection status from context menu
  • Check there's a log for addDocumentJavaScript every time you toggle protections
  • Open privacy dashboard and toggle privacy protections from there
  • Navigate back to the WebView
  • Check there's a log for addDocumentJavaScript every time you toggle protections

FF enabled

  • Open Feature flags inventory
  • Set updateScriptOnProtectionsChanged to false
  • Load a page
  • Change protection status from context menu
  • Check there's no log for addDocumentJavaScript every time you toggle protections
  • Open privacy dashboard and toggle privacy protections from there
  • Navigate back to the WebView
  • Check there's no log for addDocumentJavaScript every time you toggle protections

UI changes

n/a

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro requested a review from CDRussell October 8, 2025 11:11
@CrisBarreiro CrisBarreiro marked this pull request as ready for review October 8, 2025 11:11
@CDRussell CDRussell self-assigned this Oct 9, 2025
Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro merged commit 1ff382e into develop Oct 9, 2025
26 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/adsjd/ff-update-script-on-protections-changed branch October 9, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants