Skip to content

Add pixel for VPN menu item #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add pixel for VPN menu item #6908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea335e8
Added new pixel for vpn menu item selected
nalcalag Oct 8, 2025
fcf05d7
Added tests
nalcalag Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7902,4 +7902,46 @@ class BrowserTabViewModelTest {

override fun getPlugins(): Collection<PostMessageWrapperPlugin> = listOf(plugin)
}

@Test
fun whenVpnMenuClickedWithNotSubscribedStateThenPixelFiredWithPillStatus() {
testee.browserViewState.value = browserViewState().copy(
vpnMenuState = VpnMenuState.NotSubscribed,
)

testee.onVpnMenuClicked()

verify(mockPixel).fire(
AppPixelName.MENU_ACTION_VPN_PRESSED,
mapOf(PixelParameter.STATUS to "pill"),
)
}

@Test
fun whenVpnMenuClickedWithNotSubscribedNoPillStateThenPixelFiredWithNoPillStatus() {
testee.browserViewState.value = browserViewState().copy(
vpnMenuState = VpnMenuState.NotSubscribedNoPill,
)

testee.onVpnMenuClicked()

verify(mockPixel).fire(
AppPixelName.MENU_ACTION_VPN_PRESSED,
mapOf(PixelParameter.STATUS to "no_pill"),
)
}

@Test
fun whenVpnMenuClickedWithSubscribedStateThenPixelFiredWithSubscribedStatus() {
testee.browserViewState.value = browserViewState().copy(
vpnMenuState = VpnMenuState.Subscribed(isVpnEnabled = true),
)

testee.onVpnMenuClicked()

verify(mockPixel).fire(
AppPixelName.MENU_ACTION_VPN_PRESSED,
mapOf(PixelParameter.STATUS to "subscribed"),
)
}
}
8 changes: 6 additions & 2 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4465,18 +4465,22 @@ class BrowserTabViewModel @Inject constructor(

fun onVpnMenuClicked() {
val vpnMenuState = currentBrowserViewState().vpnMenuState
when (vpnMenuState) {
val statusParam = when (vpnMenuState) {
VpnMenuState.NotSubscribed -> {
command.value = LaunchPrivacyPro("https://duckduckgo.com/pro?origin=funnel_appmenu_android".toUri())
"pill"
}
VpnMenuState.NotSubscribedNoPill -> {
command.value = LaunchPrivacyPro("https://duckduckgo.com/pro?origin=funnel_appmenu_android".toUri())
"no_pill"
}
is VpnMenuState.Subscribed -> {
command.value = LaunchVpnManagement
"subscribed"
}
VpnMenuState.Hidden -> {} // Should not happen as menu item should not be visible
VpnMenuState.Hidden -> "" // Should not happen as menu item should not be visible
}
pixel.fire(AppPixelName.MENU_ACTION_VPN_PRESSED, mapOf(PixelParameter.STATUS to statusParam))
}

fun onAutoConsentPopUpHandled(isCosmetic: Boolean) {
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/com/duckduckgo/app/pixels/AppPixelName.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ enum class AppPixelName(override val pixelName: String) : Pixel.PixelName {
MENU_ACTION_APP_LINKS_OPEN_PRESSED("m_nav_app_links_open_menu_item_pressed"),
MENU_ACTION_DOWNLOADS_PRESSED("m_nav_downloads_menu_item_pressed"),
MENU_ACTION_AUTOFILL_PRESSED("m_nav_autofill_menu_item_pressed"),
MENU_ACTION_VPN_PRESSED("m_nav_vpn_menu_item_pressed"),

FIREPROOF_WEBSITE_ADDED("m_fw_a"),
FIREPROOF_WEBSITE_REMOVE("m_fw_r"),
Expand Down
1 change: 1 addition & 0 deletions statistics/statistics-api/src/main/java/com/duckduckgo/app/statistics/pixels/Pixel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ interface Pixel {
const val IS_TAB_SWITCHER_BUTTON_SHOWN = "is_tab_switcher_button_shown"
const val IS_FIRE_BUTTON_SHOWN = "is_fire_button_shown"
const val IS_BROWSER_MENU_BUTTON_SHOWN = "is_browser_menu_button_shown"
const val STATUS = "status"
}

object PixelValues {
Expand Down
Loading