Skip to content
This repository was archived by the owner on Nov 19, 2021. It is now read-only.

Modularize ghIssues script#1419

Open
GuiltyDolphin wants to merge 20 commits intoduckduckgo:masterfrom
GuiltyDolphin:gd/ghissues-modular
Open

Modularize ghIssues script#1419
GuiltyDolphin wants to merge 20 commits intoduckduckgo:masterfrom
GuiltyDolphin:gd/ghissues-modular

Conversation

@GuiltyDolphin
Copy link
Member

@GuiltyDolphin GuiltyDolphin commented Sep 8, 2016

Description :

This is an attempt to modularize the ghIssues script.

The aim is to add test coverage whilst modularizing as much as possible.

Reviewer notes :
References issues / PRs:

Who should be informed of this change?

@jdorweiler

Does this change have significant privacy, security, performance or deployment implications?

Doubt it.

Checklist :
  • Back end tests (perl, scripts)
  • Front end tests (js, integration)
  • Browser verification
    • IE
    • Chrome
    • Firefox
    • Safari
    • Opera
  • Mobile verification
    • iOS
    • Android

@jdorweiler
Copy link
Contributor

jdorweiler commented Sep 8, 2016

The specific example where that regex was failing was:
IA Page: https://duck.co/ia/view/python
Notice the two spaces before the url.

You could run the current script and have it print out any line with a duck.co link and use that to see what people are actually typing in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants