Skip to content

Conversation

@mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 31, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206594217596623/task/1209928658753361?focus=true

Description

Creates a new duck-player-native injected feature for use with the iOS native version of Duck Player

Background: https://app.asana.com/1/137249556945/project/1206594217596623/task/1209255140870410

Depends on: duckduckgo/privacy-configuration#3002

Testing Steps

  1. Run this C-S-S branch within the Apple branch https://github.com/duckduckgo/apple-browsers/tree/daniel/duckplayer/fe.integration
  2. Load this remote config https://duckduckgo.github.io/privacy-configuration/pr-3002/v4/ios-config.json
  3. Follow the test instructions here https://app.asana.com/1/137249556945/project/1206594217596623/task/1210224704511015?focus=true

Note: the Apple branch is still being worked on and may produce unexpected results.

Regression testing

C-S-S branch only Android Windows macOS iOS
Always ask: overlay appears
Always ask: opt-out works
Always ask: opt-in works
Always ask: remember me
Duck Player disabled
Duck Player enabled
C-S-S branch + remote config Android Windows macOS iOS
Always ask: overlay appears
Always ask: opt-out works
Always ask: opt-in works
Always ask: remember me
Duck Player disabled
Duck Player enabled

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel self-assigned this Mar 31, 2025
@mgurgel mgurgel requested a review from a team as a code owner March 31, 2025 13:14
@netlify
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d8a2ae0
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/682769ee7a9f6e000846d257
😎 Deploy Preview https://deploy-preview-1604--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Mar 31, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Mar 31, 2025

[Beta] Generated file diff

Time updated: Fri, 16 May 2025 16:38:53 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js
  • android/pages/duckplayer/dist/index.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/duckplayer/dist/index.js

File has changed

Locales
    - locales/duckplayer-locales.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/duckplayer/dist/index.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js
  • dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-native branch 2 times, most recently from c4d3f10 to 483ca6b Compare April 8, 2025 14:30
@mgurgel mgurgel marked this pull request as draft April 14, 2025 20:16
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-native branch from d166b5d to 1d6f1d8 Compare April 17, 2025 14:12
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-native branch 2 times, most recently from 0fb18f1 to 920c06d Compare May 13, 2025 11:39
@mgurgel mgurgel changed the title [WIP] Duck Player Native feature Duck Player Native feature May 13, 2025
@mgurgel mgurgel marked this pull request as ready for review May 13, 2025 16:04
@mgurgel mgurgel requested a review from shakyShane May 13, 2025 16:10
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-native branch from f931310 to d41884f Compare May 15, 2025 11:34
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-native branch from db58a2a to c91e428 Compare May 16, 2025 09:38
@mgurgel mgurgel merged commit 9fc4b79 into main May 16, 2025
14 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-native branch May 16, 2025 17:35
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants