Skip to content

Ensure getFeatureSettingEnabled behaves as expected #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanKingston merged 1 commit into from
Apr 2, 2025
Merged

Ensure getFeatureSettingEnabled behaves as expected #1607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions injected/unit-test/content-feature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ describe('ContentFeature class', () => {
expect(this.getFeatureSetting('otherTest')).toBe('enabled');
expect(this.getFeatureSetting('otherOtherTest')).toBe('ding');
expect(this.getFeatureSetting('arrayTest')).toBe('enabledArray');
// Following key doesn't exist so it should return false
expect(this.getFeatureSettingEnabled('someNonExistantKey')).toBe(false);
expect(this.getFeatureSettingEnabled('disabledStatus')).toBe(false);
expect(this.getFeatureSettingEnabled('internalStatus')).toBe(false);
expect(this.getFeatureSettingEnabled('enabledStatus')).toBe(true);
expect(this.getFeatureSettingEnabled('overridenStatus')).toBe(false);
expect(this.getFeatureSettingEnabled('disabledOverridenStatus')).toBe(true);
expect(this.getFeatureSettingEnabled('statusObject')).toBe(true);
expect(this.getFeatureSettingEnabled('statusDisabledObject')).toBe(false);
didRun = true;
}
}
Expand All @@ -23,12 +32,27 @@ describe('ContentFeature class', () => {
otherTest: 'disabled',
otherOtherTest: 'ding',
arrayTest: 'enabled',
disabledStatus: 'disabled',
internalStatus: 'internal', // not currently supported
enabledStatus: 'enabled',
overridenStatus: 'enabled',
disabledOverridenStatus: 'disabled',
statusObject: {
state: 'enabled',
bloop: true,
},
statusDisabledObject: {
state: 'disabled',
bloop2: true,
},
domains: [
{
domain: 'example.com',
patchSettings: [
{ op: 'replace', path: '/test', value: 'enabled2' },
{ op: 'replace', path: '/otherTest', value: 'enabled' },
{ op: 'replace', path: '/overridenStatus', value: 'disabled' },
{ op: 'replace', path: '/disabledOverridenStatus', value: 'enabled' },
],
},
{
Expand Down
Loading