-
Notifications
You must be signed in to change notification settings - Fork 31
Add new Theme Color content feature #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 03 Apr 2025 09:45:31 GMT Android
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed Apple
File has changed |
0410765 to
09b0a03
Compare
708c80d to
80230f1
Compare
| "state": "disabled", | ||
| "exceptions": [] | ||
| }, | ||
| "themeColor": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask why this needs to be added in all other tests but then I found this https://github.com/duckduckgo/content-scope-scripts/pull/1561/files#r2007736395 . Let's follow up on this with @shakyShane when he's back as this means new features such as this will have ever larger PRs.
mgurgel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@jaceklyp Will you be updating privacy-configuration as part of the Apple task or should we?
jaceklyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Turns out we don’t need this, and I don’t want unused code in the repo, so will close the PR. We can re-open if we need it in the future. Thanks for the help and reviews! |
Asana Task/Github Issue: https://app.asana.com/0/0/1209837728974673/f
Description
Adds a new Theme Color content feature that lets the browser extract the color found in a
<meta name=“theme-color”>.This is based largely on #1561.
The content feature can be enabled like so:
The feature then will send
themeColorFoundmessages, which follow this schema:{ "$schema": "http://json-schema.org/draft-07/schema#", "type": "object", "title": "ThemeColorFound", "required": ["themeColor", "documentUrl"], "properties": { "themeColor": { "type": ["string", "null"], "description": "The theme color value, or null if not present" }, "documentUrl": { "type": "string", "description": "The URL of the document" } } }Testing Steps
Checklist
Please tick all that apply: