Support navigation based conditional matching #1610
Conversation
Additionally ensure all checks match
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 16 Apr 2025 14:11:56 GMT Android
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed Apple
File has changed |
jonathanKingston
force-pushed
the
jkt/web-interventions-navigate
branch
from
9aae6f9 to
698d54f
Compare
|
|
||
| urlChanged(site) { | ||
| super.urlChanged(site); | ||
| this.init(); |
There was a problem hiding this comment.
This means we'll rerun rules on navigation change.
| registerForURLChanges(() => { | ||
| // The rationale for the two separate call here is to ensure that | ||
| // extensions to the class don't need to call super.urlChanged() | ||
| featureInstance.recomputeSiteObject(); |
There was a problem hiding this comment.
@dbajpeyi this is now split out so feature authors don't need to call super() as before.
There was a problem hiding this comment.
Non-blocking: do we forsee any major issues if we have both recomputeSiteObject and urlChanged being called? Can there be any inconsistencies?
| if ('navigation' in globalThis && 'addEventListener' in globalThis.navigation) { | ||
| // if the browser supports the navigation API, we can use that to listen for URL changes | ||
| // Listening to navigatesuccess instead of navigate to ensure the navigation is committed. | ||
| globalThis.navigation.addEventListener('navigatesuccess', () => { |
There was a problem hiding this comment.
@dbajpeyi the navigate event actually fired too early, I validated this works as expected. The API has a way to modify and deny navigations before they happen.
jonathanKingston
changed the title
* Add patching changes * Rename matchDomainFeatureSetting to matchConditionalFeatureSetting Additionally ensure all checks match * Add in array matching of conditions and simplify logic to prevent errors in future * PoC handle navigation centrally * Fix missing pathname * Add test case and inline contentfeature * Move url change to before callbacks, add testing * Add back listener test case * Add navigation listener, make top frame only * Document the listenForUrlChanges * Simplify listening and site computation * Add test case for fallback logic
2 participants
Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1209844047592403/f
Description
Part of: https://app.asana.com/0/481882893211075/1209844047592403/f for navigation handling.
Testing Steps
Checklist
Please tick all that apply: