-
Notifications
You must be signed in to change notification settings - Fork 28
Fix up permissions API with non hardcoded values #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 18 Aug 2025 11:18:32 GMT Android
File has changed Apple
File has changed Integration
File has changed Windows
File has changed |
7a9e42e
to
dd1a57b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but it might be worth updating the integration tests? We have some basic ones for permissions APIs already.
afe85a6
to
43e46c7
Compare
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209253361096901/task/1209488147924654?focus=true
Description
Fixes up the API with the current permission status rather than the new Chromium hardcoding they've added.
Adds a setting to allow us to control the rollout here.
Testing Steps
Checklist
Please tick all that apply: