Fix up permissions API with non hardcoded values #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 27 Aug 2025 10:52:50 GMT Android
File has changed AppleFile has changed IntegrationFile has changed WindowsFile has changed |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jonathanKingston
force-pushed
the
jkt/permissionAPIFix
branch
from
7a9e42e to
dd1a57b
Compare
nshuba
previously approved these changes
Jul 31, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jonathanKingston
force-pushed
the
jkt/permissionAPIFix
branch
from
afe85a6 to
43e46c7
Compare
Bumps [@rive-app/canvas-single](https://github.com/rive-app/rive-wasm) from 2.31.1 to 2.31.2. - [Changelog](https://github.com/rive-app/rive-wasm/blob/master/CHANGELOG.md) - [Commits](rive-app/rive-wasm@2.31.1...2.31.2) --- updated-dependencies: - dependency-name: "@rive-app/canvas-single" dependency-version: 2.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.8 to 0.25.9. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.8...v0.25.9) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add in file count check for data.files in canShare * Update check and tests * Lint fix
* Update build-and-troubleshooting.md for apple changes * Lint fix
* Auto approve patch changes to the repo * Lint fix * Ignore higher risk deps
* Ensure we check isFeatureEnabled correctly * Only trigger updates on listenForUpdateChanges enabled features (CTL) * Add bail out option for invalid messages
* Add additionalCheck for android rollout * Add test case * Simplify test case * Lint fix * Continue in the loop instead of return
* Add in file count check for data.files in canShare * Update check and tests * Lint fix * Make canShare more permissive
jonathanKingston
requested review from
shakyShane,
mgurgel,
kzar,
ladamski and
franfaccin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209253361096901/task/1209488147924654?focus=true
Description
Fixes up the API with the current permission status rather than the new Chromium hardcoding they've added.
Adds a setting to allow us to control the rollout here.
Testing Steps
Checklist
Please tick all that apply: